(fleet) remove ECR login #32150
Closed
(fleet) remove ECR login #32150
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes ECR login to avoid a sizeable dependency that has very little purpose. Before / after for the downloader: ``` -rwxr-xr-x 1 arthur.bellal 6736835 Dec 11 21:47 bin/installer/install-databricks.sh -rwxr-xr-x 1 arthur.bellal 54038960 Dec 13 14:21 bin/installer/install-databricks.sh ```
arbll
added
changelog/no-changelog
qa/done
coignetp
approved these changes
Dec 13, 2024
github-actions
bot
added
the
short review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes ECR login to avoid a sizeable dependency that has very little purpose.
Before / after for the downloader: