Fix to array shorthand not defined #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ythevalil-dd
requested review from
adedaran,
kkontoudi-dd and
florent-pajot
as code owners
ythevalil-dd
force-pushed
the
fix/to-array-shorthand-not-defined
branch
from
54d95e7
to
803e0bd
Compare
adedaran
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Why did you keep .A at lines 245, 379, 398, 481 and 508?
There was a problem hiding this comment.
The .A shorthand is no longer available for the coo_matrix object in scipy, and the other objects still using the shorthand are other types. These other types only have the shorthand implemented and don't have the standard fullname toarray method, so we need to keep the other lines as they are.
There was a problem hiding this comment.
Can you document it somewhere please (at the first occurrence of a coo_matrix calling .A)?
adedaran
approved these changes
Sep 27, 2024
adedaran
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shorhand
Afor thetoarraymethod is not always available on recent versions of scipy. This PR changes the shorthand uses to the full method name to ensure we don't run into issues on python 3.11.