Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [dinky-gateway] In Kubernetes mode, error occurs when restarting a failed task. #3954

Closed
3 tasks done
Jam804 opened this issue Nov 26, 2024 · 1 comment
Closed
3 tasks done
Assignees
Labels
Bug Something isn't working Waiting for reply Waiting for reply

Comments

@Jam804
Copy link
Contributor

Jam804 commented Nov 26, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

When running in Kubernetes mode, if a job fails at startup and the associated service is not deleted, it can cause errors due to service conflicts when restarting the job.

What you expected to happen

Automatically delete unhealthy Kubernetes services.

How to reproduce

When running in Kubernetes mode, if a job fails at startup and the associated service is not deleted, it can cause errors due to service conflicts when restarting the job.

Anything else

I have two solutions to fix this issue:

 1.  Capture exceptions when starting a service and delete the service for all exceptions except timeouts.
 2.  Launch a background thread that performs a full scan of services every minute and deletes unhealthy services.

Which approach do you think is more appropriate?

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Jam804 Jam804 added Bug Something isn't working Waiting for reply Waiting for reply labels Nov 26, 2024
Copy link

Hello @Jam804, this issue is about K8S, so I assign it to @gaoyan1998 and @zackyoungh. If you have any questions, you can comment and reply.

你好 @Jam804, 这个 issue 是关于 K8S 的,所以我把它分配给了 @gaoyan1998@zackyoungh。如有任何问题,可以评论回复。

@Jam804 Jam804 changed the title [Bug] [dinky-gateway] Bug title [Bug] [dinky-gateway] In Kubernetes mode, error occurs when restarting a failed task. Nov 26, 2024
@Jam804 Jam804 closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Waiting for reply Waiting for reply
Projects
None yet
Development

No branches or pull requests

3 participants