Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-124: verify_object Update #132

Merged
merged 21 commits into from
Sep 12, 2024
Merged

Feature-124: verify_object Update #132

merged 21 commits into from
Sep 12, 2024

Conversation

doulikecookiedough
Copy link
Contributor

Summary of Changes:

  • Rename 'verify_object' to 'delete_invalid_object' and revise pytests
  • Remove opaque method '_resolve_path' that did too many things and refactor into smaller more understandable functions
  • Clean up functions and revise respective pytests

@doulikecookiedough
Fix formatting inconsistencies caused due to pycharm settings
32b9db8
@doulikecookiedough
Update 'delete_object' in hashstore interface to only accept a pid
7cda167
@doulikecookiedough
Refactor 'delete_object' by extracting method 'delete_object_only' an…
2d674a4 
…d update signature to match the updated interface
@doulikecookiedough
Add docstring to 'delete_object_only' method and re-organize pytests
1f5868d
@doulikecookiedough
Re-organize 'delete_object_only' method in filehashstore
dff873d
@doulikecookiedough
Extract '_get_hashstore_pid_refs_path' from '_resolve_path' and updat…
eaabe3a 
…e pytests
@doulikecookiedough
Extract '_get_hashstore_cid_refs_path' from '_resolve_path' and updat…
d42d916 
…e pytests
@doulikecookiedough
Extract '_get_hashstore_data_object_path' from '_resolve_path'
d94b39c
@doulikecookiedough
Extract '_get_hashstore_metadata_path' from '_resolve_path'
232cd4d
@doulikecookiedough
Delete '_resolve_path' method and refactor affected code and pytests
7ed22b4
@doulikecookiedough
Rename '_build_path' to '_build_hashstore_data_object_path' and updat…
aabb690 
…e pytests
@doulikecookiedough
Refactor '_build_hashstore_data_object_path' by removing redundant si…
2321b6f 
…gnature value
@doulikecookiedough
Clean up '_get_hashstore_data_object_path' and '_get_hashstore_metada…
5446ee3 
…ta_path' for clarity
@doulikecookiedough
Add context and revise '_shard' docstring so that it is easier to und…
4218560 
…erstand
@doulikecookiedough
Fix docstring length
5215cc4
@doulikecookiedough
Rename 'hashstore' public APi method 'verify_object' to 'delete_inval…
d1644d0 
…id_object', revise docstrings, update filehashstore and revise/add new pytests
@doulikecookiedough
Make 'delete_object_only' a private method by renaming it to '_delete…
7535949 
…_object_only' and update pytests
@doulikecookiedough
Make 'find_object' a private method by renaming it to '_find_object' …
ca3f1b8 
…and update pytests
@doulikecookiedough
Revise docstrings to resolve linting warnings
93d81eb
@doulikecookiedough
Cleanup pytests for unused and redundant code
79ab4f0
@doulikecookiedough
Clean up methods '_store_data_only', '_find_object' and '_store_and_v…
791c17e 
…alidate_data' and review/revise/add pytests
@doulikecookiedough doulikecookiedough merged commit 15e3949 into develop Sep 12, 2024
2 checks passed
@doulikecookiedough doulikecookiedough mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doulikecookiedough