From dc4d33b12d2a4bcd06d175f4a27e4fa7a79f6add Mon Sep 17 00:00:00 2001
From: DaveO16176 <holzfamilyjunk@gmail.com>
Date: Mon, 28 Oct 2024 08:15:09 -0400
Subject: [PATCH] refactor: update variable names and syntax

---
 .../run                                       | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/root/etc/s6-overlay/s6-rc.d/init-mod-emby-mediainfo-plugin-add-package/run b/root/etc/s6-overlay/s6-rc.d/init-mod-emby-mediainfo-plugin-add-package/run
index 8d4cd465..f7821e70 100755
--- a/root/etc/s6-overlay/s6-rc.d/init-mod-emby-mediainfo-plugin-add-package/run
+++ b/root/etc/s6-overlay/s6-rc.d/init-mod-emby-mediainfo-plugin-add-package/run
@@ -18,14 +18,13 @@ fi
 # Ubuntu
 if [ -f /usr/bin/apt ]; then
 
-    if [ ${MKV_NEWER_VERSION} == "TRUE" ]; then
-        echo "Add newest version of MKVToolNix to package list"
-        PACKAGES = "mkvtoolnix ${PACKAGES}"
-        PACKAGES = "mkvtoolnix-gui ${PACKAGES}"
+    if [ $MKV_NEWER_VERSION == "TRUE" ]; then
+        echo "Add newest version of MKVToolNix to package list."
+        PACKAGES = "mkvtoolnix mkvtoolnix-gui"
     else  
         // Check to see if mkvpropedit is installed or if mkvpropedit installed and check to see if version 70.0 is installed.
         if [ ! -f /usr/bin/mkvpropedit ] || [[ -f /usr/bin/mkvpropedit ] && [ mkvpropedit --version | grep -qPo "[\d]+.[\d]+" != "70.0" ]]; then
-            echo "**** Add version 70.0 of MKVToolNIX to package list ****"
+            echo "**** Add version 70.0 of MKVToolNIX to package list. ****"
 
             # Check for MKVToolNix repository
             if [ ! -f /etc/apt/sources.list.d/mkvtoolnix.download.list ] ; then
@@ -33,8 +32,10 @@ if [ -f /usr/bin/apt ]; then
 	            curl -o /usr/share/keyrings/gpg-pub-moritzbunkus.gpg https://mkvtoolnix.download/gpg-pub-moritzbunkus.gpg
 
 	            # Add MKVToolNix repository
-	            echo "deb [arch=amd64 signed-by=/usr/share/keyrings/gpg-pub-moritzbunkus.gpg] https://mkvtoolnix.download/ubuntu/ jammy main \
-                deb-src [arch=amd64 signed-by=/usr/share/keyrings/gpg-pub-moritzbunkus.gpg] https://mkvtoolnix.download/ubuntu/ jammy main" >> /etc/apt/sources.list.d/mkvtoolnix.download.list
+	            echo "\
+                deb [arch=amd64 signed-by=/usr/share/keyrings/gpg-pub-moritzbunkus.gpg] https://mkvtoolnix.download/ubuntu/ jammy main \
+                deb-src [arch=amd64 signed-by=/usr/share/keyrings/gpg-pub-moritzbunkus.gpg] https://mkvtoolnix.download/ubuntu/ jammy main" \
+                >> /etc/apt/sources.list.d/mkvtoolnix.download.list
             fi
 
             if ! grep -E -q 'deb\s+http://archive\.ubuntu\.com/ubuntu/ +jammy.*main' /etc/apt/sources.list /etc/apt/sources.list.d/*; then
@@ -50,16 +51,15 @@ if [ -f /usr/bin/apt ]; then
                 echo "deb-src http://archive.ubuntu.com/ubuntu/ jammy universe" >> /etc/apt/sources.list
             fi
 
-            PACKAGES="mkvtoolnix=70.0.0-0~ubuntu2204bunkus01 ${PACKAGES}"
-            PACKAGES="mkvtoolnix-gui=70.0.0-0~ubuntu2204bunkus01 ${PACKAGES}
+            PACKAGES = "mkvtoolnix=70.0.0-0~ubuntu2204bunkus01 mkvtoolnix-gui=70.0.0-0~ubuntu2204bunkus01"
         else
-            echo "**** MKVToolNix already installed ****"
+            echo "**** MKVToolNix already installed. ****"
         fi
     fi
 
     echo "**** Installing packages ****"
     echo "\
-    ${PACKAGES} \
+    $PACKAGES \
     mediainfo \
     unzip" >> /mod-repo-packages-to-install.list
 fi
\ No newline at end of file