Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding reloading to Archive declarations means the mission and name arguments have to switch places #246

Open
DavidT3 opened this issue Apr 9, 2024 · 0 comments
Open

Adding reloading to Archive declarations means the mission and name arguments have to switch places #246

DavidT3 opened this issue Apr 9, 2024 · 0 comments
Assignees
@DavidT3
Labels
breaking change An issue that will result in an incompatibility with previous usages of DAXA

Comments

@DavidT3
Copy link
Owner

DavidT3 commented Apr 9, 2024

This is because when you load back, you don't need to redefine mission instances, because the loading will do it for you. Unfortunately that means that 'missions' needs to become a keyword argument, while 'archive_name' remains a non-default parameter, so they have to switch places.
@DavidT3 DavidT3 added the breaking change An issue that will result in an incompatibility with previous usages of DAXA label Apr 9, 2024
@DavidT3 DavidT3 self-assigned this Apr 9, 2024
DavidT3 added a commit that referenced this issue Apr 9, 2024
@DavidT3
The commit that made issue #246 necessary. The 'missions' argument of…
e985f6d 
… archive can now be None, if we're reading in an existing archive

Signed-off-by: David Turner <turne540@msu.edu>
DavidT3 added a commit that referenced this issue Apr 10, 2024
@DavidT3
The commit that made issue #246 necessary. The 'missions' argument of…
0bfd928 
… archive can now be None, if we're reading in an existing archive

Signed-off-by: David Turner <turne540@msu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidT3 DavidT3

Labels
breaking change An issue that will result in an incompatibility with previous usages of DAXA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidT3