Refine/revamp hydro mass profile product #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally will be a carbon copy of how the entropy profile works (I revamped that some months ago). The init is simply copied over, and no other methods are currently present (class is named NewHydrostaticMass for now, so I can easily look at the old one).
…o improved some docstrings in the SpecificEntropy profile class.
…ocstrings and type hints.
…y - the first part of the 'mass' method is essentially the same as the entropy method of SpecificEntropy, handling all the different ways we can get density and temperature information. The next part thing need to is implement derivative calculation, then add the actual hydrostatic mass calculation (making sure to support radius uncertainties like the old one did). For issue #1260
…of the revamped hydrostatic mass profile. For issue #1260
… setup) in the new hydro mass profile init. Also improved over the original, as apparently for the mass profile values the radius uncertainties were not being passed. For issue #1260
…uding radii errors - have added it to the density model realisation approach (as it was in the original hydrostatic mass profile calculation). For issue #1260
… method should now use the radius distribution rather than a single value. For issue #1260
…file calculations - only for the smooth model mode currently. For issue #1260
…e the density gradient from non-interpolated data points in the new hydro mass setup. For issue #1260
…y determine the density gradient. For issue #1260
…r the new mass profile calculation
…lation but mismatched bins scenario) for the new hydrostatic mass calculation. For issue #1260
… the opposite to the entropy calculation as we tend to use keV for that, so the conversion I copied over was going the wrong way around. For issue #1260
…K/{insert distance unit}... think I might be tired. For issue #1260
…ion array and the radii array (could well be a matrix transpose that I removed earlier - added it back in to test). For issue #1260
…rofile class - means no error will be raised if negative mass is measured. Indirectly for issue #1260 (will now do the same for entropy whilst I think about it).
…units are the same, rather than explicitly look at the Python instance type. For issue #1260
… for cumulative mass rather than mass density) - this will be useful for fitting hydrostatic mass profiles. For issue #1260 (sort of)
…ionaries which let profiles look up what models they are allowed to be fit with. For issue #1260 (sort of)
… prior in there when there should not have been. For issue #1260 (sort of)
…latex code outside of a math environment so it didn't render properly.
…ould. Putting in a stupid test
…ould. Putting in a stupid test
…ould. Putting in a stupid test
… that it provides a label of the value/error on each parameter.
…thod be formatted more nicely.
…thod be formatted EVEN more nicely.
… the new hydro mass profile class. For issue #1260
…ly measure masses at custom radii properly. For issue #1260
…ofile class can calculate distributions for a single radius input. For issue #1260
…ofile class can calculate distributions for a single radius input. SECOND ATTEMPT. For issue #1260
…t-method mass measurement working. For issue #1260
…ng way around axis wise
…a-point-driven mass profiles. Indirectly for issue #1260
… it can take custom radii (though radii 'errs' aren't working yet).
…#1260, to let the new hydro mass profile refit a model if the number of samples doesn't match that specified in the init
…s is found when declaring a mass profile now. For issue #1260
… models can either be strings or model instances. Indirectly for issue #1260
… models can either be strings or model instances. Indirectly for issue #1260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.