-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine/revamp hydro mass profile product #1275
Commits on Nov 19, 2024
-
Began the creation of the revamped hydrostatic mass profile - essenti…
…ally will be a carbon copy of how the entropy profile works (I revamped that some months ago). The init is simply copied over, and no other methods are currently present (class is named NewHydrostaticMass for now, so I can easily look at the old one).
Configuration menu - View commit details
-
Copy full SHA for 6707bf9 - Browse repository at this point
Copy the full SHA 6707bf9View commit details -
Building out the bones of the revamped hydrostatic mass profile - als…
…o improved some docstrings in the SpecificEntropy profile class.
Configuration menu - View commit details
-
Copy full SHA for 9e3cb44 - Browse repository at this point
Copy the full SHA 9e3cb44View commit details -
Swept through the hydro mass profile class and mildly improved some d…
…ocstrings and type hints.
Configuration menu - View commit details
-
Copy full SHA for 4da4ed4 - Browse repository at this point
Copy the full SHA 4da4ed4View commit details -
Starting to get the new hydrostatic mass profile to full functionalit…
…y - the first part of the 'mass' method is essentially the same as the entropy method of SpecificEntropy, handling all the different ways we can get density and temperature information. The next part thing need to is implement derivative calculation, then add the actual hydrostatic mass calculation (making sure to support radius uncertainties like the old one did). For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 2dc01c8 - Browse repository at this point
Copy the full SHA 2dc01c8View commit details -
Hopefully set up the radius distribution creation in the mass method …
…of the revamped hydrostatic mass profile. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for fe06a33 - Browse repository at this point
Copy the full SHA fe06a33View commit details -
Missed some bits to convert to mass (rather than the original entropy…
… setup) in the new hydro mass profile init. Also improved over the original, as apparently for the mass profile values the radius uncertainties were not being passed. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 9b60704 - Browse repository at this point
Copy the full SHA 9b60704View commit details -
Working through the mass method the new hydro mass class, slowly incl…
…uding radii errors - have added it to the density model realisation approach (as it was in the original hydrostatic mass profile calculation). For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 7d400e3 - Browse repository at this point
Copy the full SHA 7d400e3View commit details -
The density interpolating option in the new hydro mass class 'mass()'…
… method should now use the radius distribution rather than a single value. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 91c144b - Browse repository at this point
Copy the full SHA 91c144bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e9b800 - Browse repository at this point
Copy the full SHA 5e9b800View commit details -
Added density derivative calculation back into the new hydro mass pro…
…file calculations - only for the smooth model mode currently. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 9cddd3e - Browse repository at this point
Copy the full SHA 9cddd3eView commit details
Commits on Nov 20, 2024
-
Trying to use the numerical gradient measurement from numpy to measur…
…e the density gradient from non-interpolated data points in the new hydro mass setup. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for d68c7a5 - Browse repository at this point
Copy the full SHA d68c7a5View commit details -
Now trying to use the interpolated density profile data to numericall…
…y determine the density gradient. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for a531414 - Browse repository at this point
Copy the full SHA a531414View commit details -
Still trying to make numerical differentiation of data points work fo…
…r the new mass profile calculation
Configuration menu - View commit details
-
Copy full SHA for 21508c2 - Browse repository at this point
Copy the full SHA 21508c2View commit details -
Bodging in the temperature derivatives now (apart from the no-interpo…
…lation but mismatched bins scenario) for the new hydrostatic mass calculation. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for eafcd5f - Browse repository at this point
Copy the full SHA eafcd5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for edbbc42 - Browse repository at this point
Copy the full SHA edbbc42View commit details -
Need to make sure that temperature is in Kelvin rather than keV - was…
… the opposite to the entropy calculation as we tend to use keV for that, so the conversion I copied over was going the wrong way around. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 6d2f35c - Browse repository at this point
Copy the full SHA 6d2f35cView commit details -
Was trying to convert the temperature gradient to Kelvin rather than …
…K/{insert distance unit}... think I might be tired. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 3defee4 - Browse repository at this point
Copy the full SHA 3defee4View commit details -
Figuring out why there is a shape mismatch between the mass distribut…
…ion array and the radii array (could well be a matrix transpose that I removed earlier - added it back in to test). For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 05c7e93 - Browse repository at this point
Copy the full SHA 05c7e93View commit details -
Added an 'allow_unphysical' flag to the declaration of the new mass p…
…rofile class - means no error will be raised if negative mass is measured. Indirectly for issue #1260 (will now do the same for entropy whilst I think about it).
Configuration menu - View commit details
-
Copy full SHA for ae110a4 - Browse repository at this point
Copy the full SHA ae110a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2593f2e - Browse repository at this point
Copy the full SHA 2593f2eView commit details -
Changed the BaseAggregateProfile init to just check that the x and y …
…units are the same, rather than explicitly look at the Python instance type. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for cf8e060 - Browse repository at this point
Copy the full SHA cf8e060View commit details -
Added a basic XGA-model implementation of the NFW profile (integrated…
… for cumulative mass rather than mass density) - this will be useful for fitting hydrostatic mass profiles. For issue #1260 (sort of)
Configuration menu - View commit details
-
Copy full SHA for 9a13f6e - Browse repository at this point
Copy the full SHA 9a13f6eView commit details -
Made sure to add the new mass model section of XGA models to the dict…
…ionaries which let profiles look up what models they are allowed to be fit with. For issue #1260 (sort of)
Configuration menu - View commit details
-
Copy full SHA for 786b0ca - Browse repository at this point
Copy the full SHA 786b0caView commit details -
Corrected a small mistake in the NFW mass model - had a dimensionless…
… prior in there when there should not have been. For issue #1260 (sort of)
Configuration menu - View commit details
-
Copy full SHA for 5664985 - Browse repository at this point
Copy the full SHA 5664985View commit details -
The 'nice' parameter name for the NFW density parameter had the \rho …
…latex code outside of a math environment so it didn't render properly.
Configuration menu - View commit details
-
Copy full SHA for 15c94b4 - Browse repository at this point
Copy the full SHA 15c94b4View commit details -
Don't know that the NFW model units are working like I thought they w…
…ould. Putting in a stupid test
Configuration menu - View commit details
-
Copy full SHA for 76a2e7f - Browse repository at this point
Copy the full SHA 76a2e7fView commit details -
Don't know that the NFW model units are working like I thought they w…
…ould. Putting in a stupid test
Configuration menu - View commit details
-
Copy full SHA for d572f3a - Browse repository at this point
Copy the full SHA d572f3aView commit details -
Don't know that the NFW model units are working like I thought they w…
…ould. Putting in a stupid test
Configuration menu - View commit details
-
Copy full SHA for 960751b - Browse repository at this point
Copy the full SHA 960751bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 176e923 - Browse repository at this point
Copy the full SHA 176e923View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7cb341 - Browse repository at this point
Copy the full SHA d7cb341View commit details
Commits on Nov 21, 2024
-
Changing the start parameters and priors for NFW to the msun/kpc^3 un…
…it - this really shouldn't matter and clearly I need to fix how models deal with units. Really just want a fit working though, for issue #1260
Configuration menu - View commit details
-
Copy full SHA for 1721844 - Browse repository at this point
Copy the full SHA 1721844View commit details -
Trying something for the new hydrostatic mass profile measurements - …
…setting any value in the mass distribution less than zero to be NaN. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 6337fa4 - Browse repository at this point
Copy the full SHA 6337fa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ac7a9f - Browse repository at this point
Copy the full SHA 3ac7a9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 590e994 - Browse repository at this point
Copy the full SHA 590e994View commit details -
Attempting to understand what is going on with profile fitting and pa…
…rameter units. There are dimensionless parameters used in the fitting process - as I assume using quantities was causing problems when I developed it, but how then am I gonna solve the problem of the model prediction being in the wrong unit to compare to the data?
Configuration menu - View commit details
-
Copy full SHA for a017962 - Browse repository at this point
Copy the full SHA a017962View commit details -
I am attempting to address this problem completely by ensuring that t…
…he data of a profile are converted to the current output unit of the model. For issue #1267
Configuration menu - View commit details
-
Copy full SHA for 5955d16 - Browse repository at this point
Copy the full SHA 5955d16View commit details -
Returning the NFW profile to the original start parameters and priors…
Configuration menu - View commit details
-
Copy full SHA for 80b116d - Browse repository at this point
Copy the full SHA 80b116dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e4b130 - Browse repository at this point
Copy the full SHA 8e4b130View commit details -
still nope, think perhaps because the NLLS fit is doing the same sort…
… of thing as emcee. For issue #1267
Configuration menu - View commit details
-
Copy full SHA for 1c5a0a1 - Browse repository at this point
Copy the full SHA 1c5a0a1View commit details -
Converting the data for regression in the emcee and nlls fit methods …
…of BaseProfile1D to what I FINALLY HOPE is the right unit. For issue #1267
Configuration menu - View commit details
-
Copy full SHA for dd422ef - Browse repository at this point
Copy the full SHA dd422efView commit details -
I swear I'm not doing this on purpose... I was passing the start para…
…meters incorrectly to the model to get the raw output unit. (by the way, beforehand I was actually using the model self call method, which actually auto-converts the output to the set unit of the model, so wasn't helping us here). For issue #1267
Configuration menu - View commit details
-
Copy full SHA for 4b63a26 - Browse repository at this point
Copy the full SHA 4b63a26View commit details -
Make sure to convert the output from a model's get_realisations metho…
…d to the specified y unit of the model. For issue #1267
Configuration menu - View commit details
-
Copy full SHA for 5c8ee21 - Browse repository at this point
Copy the full SHA 5c8ee21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b0cb40 - Browse repository at this point
Copy the full SHA 8b0cb40View commit details -
nevermind - anyway just need to add the last derivatives of temperatu…
…re and density. These are for the cases where there are more radii points for the mass profile than there are radii or density, and no interpolation. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for ae93196 - Browse repository at this point
Copy the full SHA ae93196View commit details -
Added first attempt at temp/dens gradient for temp/dens profiles with…
… mismatched radii and interpolation turned off (in the new hydrostatic mass profile implementation). For issue #1260
Configuration menu - View commit details
-
Copy full SHA for b9a2294 - Browse repository at this point
Copy the full SHA b9a2294View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49241bf - Browse repository at this point
Copy the full SHA 49241bfView commit details -
Ridiculous amount of matrix transposing going on to make numerical de…
…rivates work on the non-interpolation case. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 4d05376 - Browse repository at this point
Copy the full SHA 4d05376View commit details -
May have been using the wrong radii values for numerical derivative o…
…f temp and dens non-interpolation mode in the new hydro mass implementation. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 10b1e5c - Browse repository at this point
Copy the full SHA 10b1e5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6a7464 - Browse repository at this point
Copy the full SHA e6a7464View commit details -
I think the new hydrostatic mass profile 'mass()' method is now featu…
…re complete. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for a78e3fe - Browse repository at this point
Copy the full SHA a78e3feView commit details -
Hopefully made the getdist corner plots in the BaseProfile method inc…
…lude the unit in the labels. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 89394c7 - Browse repository at this point
Copy the full SHA 89394c7View commit details -
Making getdist axis labels in BaseProfile include the nicely rendered…
… unit in a square bracket. For issue #1260 indirectly.
Configuration menu - View commit details
-
Copy full SHA for 477eb71 - Browse repository at this point
Copy the full SHA 477eb71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 818edd4 - Browse repository at this point
Copy the full SHA 818edd4View commit details -
Updated the look of the quick 'view_BLAH_distribution' methods of the…
… profile classes.
Configuration menu - View commit details
-
Copy full SHA for 160dab2 - Browse repository at this point
Copy the full SHA 160dab2View commit details -
Updated the look of the quick 'view_BLAH_distribution' methods of the…
… profile classes.
Configuration menu - View commit details
-
Copy full SHA for 189b2dd - Browse repository at this point
Copy the full SHA 189b2ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for de4c655 - Browse repository at this point
Copy the full SHA de4c655View commit details -
Configuration menu - View commit details
-
Copy full SHA for a409f65 - Browse repository at this point
Copy the full SHA a409f65View commit details -
Attempting an improvement to the par_dist_view method of BaseModel so…
… that it provides a label of the value/error on each parameter.
Configuration menu - View commit details
-
Copy full SHA for 00912d9 - Browse repository at this point
Copy the full SHA 00912d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c483a7a - Browse repository at this point
Copy the full SHA c483a7aView commit details -
Hopefully make big long numbers in the labels of the par_dist_view me…
…thod be formatted more nicely.
Configuration menu - View commit details
-
Copy full SHA for 4d48231 - Browse repository at this point
Copy the full SHA 4d48231View commit details -
Hopefully make big long numbers in the labels of the par_dist_view me…
…thod be formatted EVEN more nicely.
Configuration menu - View commit details
-
Copy full SHA for 8494c78 - Browse repository at this point
Copy the full SHA 8494c78View commit details -
Corrected a label latex error I added in the view_mass_dist method of…
… the new hydro mass profile class. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 34a56f9 - Browse repository at this point
Copy the full SHA 34a56f9View commit details -
Working to make the new hydro mass profile class 'mass' method actual…
…ly measure masses at custom radii properly. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 268b031 - Browse repository at this point
Copy the full SHA 268b031View commit details -
Maybe made sure that the mass() method of the new hydrostatic mass pr…
…ofile class can calculate distributions for a single radius input. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 59d171d - Browse repository at this point
Copy the full SHA 59d171dView commit details -
Maybe made sure that the mass() method of the new hydrostatic mass pr…
…ofile class can calculate distributions for a single radius input. SECOND ATTEMPT. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 8d9f92e - Browse repository at this point
Copy the full SHA 8d9f92eView commit details -
Still messing around getting the custom radius interpolated-data-poin…
…t-method mass measurement working. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 7562aee - Browse repository at this point
Copy the full SHA 7562aeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 140371a - Browse repository at this point
Copy the full SHA 140371aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e092061 - Browse repository at this point
Copy the full SHA e092061View commit details -
Configuration menu - View commit details
-
Copy full SHA for eabd87c - Browse repository at this point
Copy the full SHA eabd87cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99b171e - Browse repository at this point
Copy the full SHA 99b171eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb13442 - Browse repository at this point
Copy the full SHA cb13442View commit details -
Configuration menu - View commit details
-
Copy full SHA for fea3855 - Browse repository at this point
Copy the full SHA fea3855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 630db4d - Browse repository at this point
Copy the full SHA 630db4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34db680 - Browse repository at this point
Copy the full SHA 34db680View commit details -
Things seem to be working now - but the temp and dens der are the wro…
…ng way around axis wise
Configuration menu - View commit details
-
Copy full SHA for aa5875c - Browse repository at this point
Copy the full SHA aa5875cView commit details -
Added an error to rad_check so that no-one can try to extrapolate dat…
…a-point-driven mass profiles. Indirectly for issue #1260
Configuration menu - View commit details
-
Copy full SHA for 03ca704 - Browse repository at this point
Copy the full SHA 03ca704View commit details -
Added a not implemented error to the gas density profile mass calcula…
Configuration menu - View commit details
-
Copy full SHA for 4324c7e - Browse repository at this point
Copy the full SHA 4324c7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5180a86 - Browse repository at this point
Copy the full SHA 5180a86View commit details -
Altering the baryon_fraction_profile method of new hydro mass so that…
… it can take custom radii (though radii 'errs' aren't working yet).
Configuration menu - View commit details
-
Copy full SHA for 25f1574 - Browse repository at this point
Copy the full SHA 25f1574View commit details
Commits on Nov 22, 2024
-
Added a remove_model_fit method to BaseProfile1D. Indirectly for issue …
…#1260, to let the new hydro mass profile refit a model if the number of samples doesn't match that specified in the init
Configuration menu - View commit details
-
Copy full SHA for 1c2a8c7 - Browse repository at this point
Copy the full SHA 1c2a8c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c55de2 - Browse repository at this point
Copy the full SHA 7c55de2View commit details -
Think that maybe models will be refit if mismatching number of sample…
…s is found when declaring a mass profile now. For issue #1260
Configuration menu - View commit details
-
Copy full SHA for 1b6dcb7 - Browse repository at this point
Copy the full SHA 1b6dcb7View commit details -
The model refitting in new hydro mass profile didn't work because the…
… models can either be strings or model instances. Indirectly for issue #1260
Configuration menu - View commit details
-
Copy full SHA for 6211a01 - Browse repository at this point
Copy the full SHA 6211a01View commit details -
The model refitting in new hydro mass profile didn't work because the…
… models can either be strings or model instances. Indirectly for issue #1260
Configuration menu - View commit details
-
Copy full SHA for e17aee0 - Browse repository at this point
Copy the full SHA e17aee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a1a25b - Browse repository at this point
Copy the full SHA 4a1a25bView commit details