Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft Deletes Not Working As Expected #45

Open
iamh2o opened this issue Jul 11, 2024 · 0 comments
Open

Soft Deletes Not Working As Expected #45

iamh2o opened this issue Jul 11, 2024 · 0 comments

Comments

@iamh2o
Copy link
Contributor

iamh2o commented Jul 11, 2024

Soft deletes work, but in reviewing the code the scope at which they are being managed is to high, and should be moved from the database connection. I think... I also think that the is_deleted property in use should not be named this way or be a boolean. Instead it should be a del_state_to_include = 'deleted only', 'not deleted only', 'all'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant