Codefactor vuln fixes #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Pull Request Template ### Prerequisites <!-- Take a couple of minutes to help our maintainers work faster by checking of the pre-requisites. --> - [x] I have [searched](https://github.com/DefinetlyNotAI/Logicytics/pulls) for duplicate or closed issues. - [x] I have read the [contributing guidelines](https://github.com/DefinetlyNotAI/Logicytics/blob/main/CONTRIBUTING.md). - [x] I have followed the instructions in the [wiki](https://github.com/DefinetlyNotAI/Logicytics/wiki) about contributions. - [x] I have updated the documentation accordingly, if required. - [ ] I have added tests to cover my changes, and they have passed, if required. - [ ] I have tested my code with the `--dev` flag, if required. ### PR Type <!-- Take a couple of minutes to help our maintainers work faster by telling us what is the PR guided on. --> - [ ] Bug fix <!-- Non-Breaking Bug Fix - Usually relates to fixing an issue --> - [ ] New feature <!-- Non-Breaking Change that adds a new feature --> - [ ] Refactoring <!-- Non-Breaking Change that modifies existing code to refactor it to become more organised --> - [ ] Documentation update <!-- Non-Breaking Change that modifies existing documentation to refactor it or add extra comments - either wiki, md files or code is included here --> - [x]⚠️ Breaking change⚠️ <!--⚠️ Breaking Bug Fix / New Addition that changes how Logicytics works⚠️ --> ### Description Updating the branch to mitigate future merge conflict ### Motivation and Context Merge conflict update ### Binaries Not now ### Issues Fixed Will be linked to #107
Added feature to allow new line in log's
Added feature to allow new line in log's Also fixed another bug with _dev.py that doesn't allow it to be used due to how its executed
…lete critical log error codes
Also reformatted code, quick test and checked any warning and errors - also redoc some stuff
It decided to increase duplicate logs double each time its called
…factor-vuln-fixes
DefinetlyNotAI
added
type/Documentation
Closed
3 tasks
|
🚨 Hi @DefinetlyNotAI. Thanks for your contribution, as the |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 23cf375 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Prerequisites
--devflag, if required.PR Type
update
Description
HUGE update for 2.3.0 -> Added 1 feature, fixed and tracked 12+ bugs AND made development easier,
Motivation and Context
Why not, I was bored lol
Binaries
Not now, I will later attach
Issues Fixed
#107