Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QGIS plugin has enabled buttons when no model is loaded #1678

Open
deltamarnix opened this issue Aug 1, 2024 · 1 comment
Open

QGIS plugin has enabled buttons when no model is loaded #1678

deltamarnix opened this issue Aug 1, 2024 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior QGIS Ribasim QGIS plugin

Comments

@deltamarnix
Copy link
Contributor

  • Open a fresh QGIS
  • Open the Ribasim QGIS plugin
  • Press the "Add to QGIS" button: does nothing, but it's enabled.
  • Press the "Remove from dataset" button: shows popup with "Deleting..." and you need to press Yes/No", pressing either does nothing.

I believe these buttons should not be enabled when no model is loaded. Should listen to a signal in order to enable/disable.
@deltamarnix deltamarnix added QGIS Ribasim QGIS plugin bug Indicates an unexpected problem or unintended behavior labels Aug 1, 2024
@Huite
Copy link
Contributor

Huite commented Aug 2, 2024

Good catch, most of the other buttons are properly enabled/disabled.

@deltamarnix deltamarnix mentioned this issue Aug 2, 2024
Merged
evetion pushed a commit that referenced this issue Aug 27, 2024
@deltamarnix @visr
Initial qgis test plan (#1691)
3e70543 
An initial QGIS test plan for the plugin. There are still some tests to
be written.
I have also performed all these tests and created quite some new
reports.
There is also a known issues page for all of Ribasim, as we have some
things that simply don't work as expected.

New issues:

* #1678 
* #1679 
* #1681 
* #1682 
* #1683 
* #1684 
* #1685 
* #1688 
* #1689 
* #1690 

Fixes #320

---------

Co-authored-by: Martijn Visser <mgvisser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior QGIS Ribasim QGIS plugin
Projects
Ribasim
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Huite @deltamarnix