-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate convergence options #1700
Comments
As I mentioned in chat, I think you're still going to need those. Even though e.g. EulerImplicit is unconditionally stable, you will either get very small time steps (with adaptive time stepping) or poor convergence (fixed time step). Any time a droplet of water comes in, The adaptive timestepper notices this so Alternatively, with fixed time step it'll have trouble converging because
|
Adding backtracking in the nonlinear solver settings (#1697) gave a huge speedup, probably because the convergence of the nonlinear solver is much faster. To get more insight into this speedup, we can look at the difference in solver stats (an output file for this was introduced in #1677).
Now that we have this speedup, we should also re-asses the other convergence measures we have in place:
isoutofdomain
. We probably want to keep this, but it's good to know whether it still being triggered sometimesAlso, we still might need this for depleting basins.
The text was updated successfully, but these errors were encountered: