Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document known issue: (small) negative flows from e.g. Terminals #1838

Open
visr opened this issue Sep 23, 2024 · 3 comments · Fixed by #1899
Open

Document known issue: (small) negative flows from e.g. Terminals #1838

visr opened this issue Sep 23, 2024 · 3 comments · Fixed by #1899
Labels
documentation Improvements or additions to documentation

Comments

@visr
Copy link
Member

visr commented Sep 23, 2024

  • Add explanation of callback check
  • In usage.qmd: add explanation of water balance tolerance options (too large error probably indicates error in the code or floating point errors)

Originally posted by @SouthEndMusic in #1828 (comment)
@visr visr added the documentation Improvements or additions to documentation label Sep 23, 2024
@evetion
Copy link
Member

evetion commented Oct 8, 2024

Add limitations of current version.

@SouthEndMusic SouthEndMusic mentioned this issue Oct 10, 2024
Merged
visr added a commit that referenced this issue Oct 10, 2024
@SouthEndMusic @visr
Add explanation of water balance error options (#1899)
610cc73 
Fixes #1838.

---------

Co-authored-by: Martijn Visser <mgvisser@gmail.com>
@evetion
Copy link
Member

evetion commented Oct 10, 2024

#1899 Did not address that users can see (small) negative flows from Terminals.

@visr
Copy link
Member Author

visr commented Oct 10, 2024

Ah right, reopening for that. Unless this becomes fixed altogether with #1897.

@visr visr reopened this Oct 10, 2024
@visr visr changed the title Water balance error doc additions Document known issue: (small) negative flows from e.g. Terminals Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Ribasim
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explanation of water balance error options Deltares/Ribasim
2 participants
@visr @evetion