Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User demand should return concentrations instead of removing it #1894

Open
evetion opened this issue Oct 9, 2024 · 5 comments
Open

User demand should return concentrations instead of removing it #1894

evetion opened this issue Oct 9, 2024 · 5 comments
Labels
enhancement New feature or request waterquality Issues related to Delwaq coupling/functionality

Comments

@evetion
Copy link
Member

evetion commented Oct 9, 2024

Because the UserDemand in and outflows are on separate edges, #1849 sees them as different boundaries altogether, ignoring that the return flow is actually a part of the inflow.

@evetion evetion added enhancement New feature or request waterquality Issues related to Delwaq coupling/functionality labels Oct 9, 2024
@visr
Copy link
Member

visr commented Oct 10, 2024

In time, we may want to support some process or mass injection or removal at the UserDemand node. Until then, indeed it is best to assume the outflow concentrations are equal to the inflow concentrations.

@evetion
Copy link
Member Author

evetion commented Oct 10, 2024

Injection is already support in the current PR, there's the UserDemandConcentration table.

@visr
Copy link
Member

visr commented Oct 10, 2024

That setting the concentration, not injection, right? Injection adds mass to the inflow.

@evetion
Copy link
Member Author

evetion commented Oct 10, 2024

Each outflow from the UserDemand is multiplied times the set concentration of the UserDemandConcentration table, so it's a mass injection?

@gijsber
Copy link
Contributor

gijsber commented Oct 10, 2024

The result is a mass injection and I assume that the User demand return flow has only one concentration, either as specified in this table or (when this table is not populated by the user) the same concentration as the abstraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waterquality Issues related to Delwaq coupling/functionality
Projects
Status: To do
Development

No branches or pull requests

3 participants