Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: go to implementation / list implementations #958

Closed
disrupted opened this issue Dec 17, 2024 · 5 comments
Closed

feature: go to implementation / list implementations #958

disrupted opened this issue Dec 17, 2024 · 5 comments
Labels
needs investigation awaiting verification by a maintainer that the issue is valid pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature

Comments

@disrupted
Copy link

disrupted commented Dec 17, 2024

the Pylance team rolled out preliminary support for go to implementation in the latest pre-release. https://github.com/microsoft/pylance-release/releases/tag/2024.12.100 and more specifically microsoft/pylance-release#4329

They are also further discussing the subject in microsoft/pylance-release#6775. Afaict this feature won't be available in Pyright.

Are there any plans to support this feature in BasedPyright?

@DetachHead
Copy link
Owner

i've looked into this before and from what i remember there doesn't seem to be a language server feature for this, so it would need to be implemented in the vscode extension.

@KotlinIsland we already have an issue for this right? i can't find it

@DetachHead DetachHead added pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature needs investigation awaiting verification by a maintainer that the issue is valid labels Dec 17, 2024
@disrupted
Copy link
Author

Could you elaborate what you mean by that? Afaict textDocument/implementation is part of the official LSP spec. https://microsoft.github.io/language-server-protocol/specifications/specification-3-14/#textDocument_implementation

@DetachHead
Copy link
Owner

im probably misremembering then, i remember commenting about the situation on the existing issue but i cant find it lol

@KotlinIsland
Copy link
Collaborator

@DetachHead
Copy link
Owner

thanks, closing in favor of that issue

@DetachHead DetachHead closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation awaiting verification by a maintainer that the issue is valid pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature
Projects
None yet
Development

No branches or pull requests

3 participants