Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not be @'d in the comments #364

Open
jagregory opened this issue Dec 13, 2024 · 2 comments
Open

Option to not be @'d in the comments #364

jagregory opened this issue Dec 13, 2024 · 2 comments

Comments

@jagregory
Copy link

Is your feature request related to a problem

I have a lot of Terraform matrix jobs and when they run in a PR I get @'d in the comments... a lot.

Describe the solution you'd like

It'd be awesome if I could disable @'ing in the action, so I don't get spammed with notifications when my PRs run.

Describe alternatives you've considered

Turning my phone off. 😆

@rdhar
Copy link
Member

rdhar commented Dec 13, 2024

Thanks @jagregory, this issue/request is way too relatable!

Trying to figure how best to address it:

  • Simplest would be to add something like a "mention-author" option to toggle @'ing. But that's yet another input parameter to add to the list.
  • Alternatively, add an option to specify the line like, "By <author> at <timestamp> (<link>)". BUT that's still another input parameter, and way more complex to interpolate!
  • Got some other ideas?

As an aside, would you mind sharing a little more about your experience with this Action? External feedback is rare, especially from matrix users, so keen to know how you're getting along.

@jagregory
Copy link
Author

I have one pipeline which can sometimes trigger up-to 40 matrixed terraform jobs 😅

I was thinking the first option would be the simplest, just template the inclusion/exclusion of the @ in the message body so the author doesn't get tagged. Anything more than that feels like it would get complicated quite quickly.

As for feedback, it's been a very helpful action and I tried a couple of alternatives but found this one the easiest to use and produces the most useful output. I particularly like the short summary of changes which is great for an at-a-glance look, and the inclusion of a diff as well so I don't have to pour over the full plan to understand what's changing. Specifically for matrix use: I don't love that there's a comment created per job but I understand why that is. If there was a way to "fan-in" after a matrix job to post a single summary comment that would be amazing, but I think that's a lot of complexity and might not be worth the effort.

Thinking out loud (and back to the original issue) perhaps an option to only tag the author in a comment when a diff has changes? That would be probably be more useful than just disabling the tagging entirely. Or possibly a variation on #361 but more about posting comments than uploading plans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants