Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyright #619

Open
callumforrester opened this issue Sep 5, 2024 · 8 comments · May be fixed by #632
Open

Move to pyright #619

callumforrester opened this issue Sep 5, 2024 · 8 comments · May be fixed by #632
Labels
dev-environment Issues for improving the developer environment/experience enhancement New feature or request good first issue Good for newcomers

Comments

@callumforrester
Copy link
Contributor

Acceptance Criteria

@callumforrester callumforrester added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2024
@callumforrester callumforrester added the dev-environment Issues for improving the developer environment/experience label Sep 11, 2024
@stan-dot
Copy link
Contributor

at the moment, python-copier-template pyproject.toml does not contain references to pyright, neither does it have it as a dev dependency

https://github.com/DiamondLightSource/python-copier-template/blob/main/pyproject.toml

@callumforrester
Copy link
Contributor Author

@stan-dot That is for setting up a dev environment to build/test the template, it is not the file used to make projects, you're looking for this: https://github.com/DiamondLightSource/python-copier-template/blob/main/template/pyproject.toml.jinja

@stan-dot
Copy link
Contributor

ah right, so we need to add pyright to the dev dependencies, second add

tool.pyright]
typeCheckingMode = "standard"
reportMissingImports = false # Ignore missing stubs in imported modules

third, remove mypy references

@stan-dot
Copy link
Contributor

25 errors in src, 9 errors in tests

@stan-dot
Copy link
Contributor

working on it

@stan-dot
Copy link
Contributor

sim_motor types issues - might ignore but alternatively just delete

@stan-dot
Copy link
Contributor

task worker state is also problematic

@stan-dot
Copy link
Contributor

also run engine 'run' part with the hooks is unclear

@stan-dot stan-dot linked a pull request Sep 11, 2024 that will close this issue
4 tasks
@stan-dot stan-dot changed the title Move to pyright Move to pyright - awaits dodal change Oct 24, 2024
@stan-dot stan-dot changed the title Move to pyright - awaits dodal change Move to pyright Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-environment Issues for improving the developer environment/experience enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@callumforrester @stan-dot and others