-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pyright #619
Comments
at the moment, python-copier-template https://github.com/DiamondLightSource/python-copier-template/blob/main/pyproject.toml |
@stan-dot That is for setting up a dev environment to build/test the template, it is not the file used to make projects, you're looking for this: https://github.com/DiamondLightSource/python-copier-template/blob/main/template/pyproject.toml.jinja |
ah right, so we need to add pyright to the dev dependencies, second add
third, remove mypy references |
25 errors in |
working on it |
sim_motor types issues - might ignore but alternatively just delete |
task worker state is also problematic |
also run engine 'run' part with the hooks is unclear |
Acceptance Criteria
pyproject.toml
contains pyright config from https://github.com/DiamondLightSource/python-copier-templatetox -e type-checking
runspyright
insead ofmypy
The text was updated successfully, but these errors were encountered: