You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A number of the issues found in #463 were not caught because the tests in test_rotation_callbacks are run against a fake_rotation_scan rather than the real one, which means that we have no tests covering the communication between the real rotation plan and the real callbacks. #477 adds a couple but it would be better if test_rotation_callbacks used the real plan.
Acceptance Criteria
test_rotation_callbacks tests against the real plan (using the simulator should still be a good test)
A number of the issues found in #463 were not caught because the tests in
test_rotation_callbacks
are run against afake_rotation_scan
rather than the real one, which means that we have no tests covering the communication between the real rotation plan and the real callbacks. #477 adds a couple but it would be better iftest_rotation_callbacks
used the real plan.Acceptance Criteria
test_rotation_callbacks
tests against the real plan (using the simulator should still be a good test)The text was updated successfully, but these errors were encountered: