Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the rotation callbacks against the real rotation plan #479

Open
DominicOram opened this issue Sep 12, 2024 · 0 comments
Open

Test the rotation callbacks against the real rotation plan #479

DominicOram opened this issue Sep 12, 2024 · 0 comments

Comments

@DominicOram
Copy link
Contributor

A number of the issues found in #463 were not caught because the tests in test_rotation_callbacks are run against a fake_rotation_scan rather than the real one, which means that we have no tests covering the communication between the real rotation plan and the real callbacks. #477 adds a couple but it would be better if test_rotation_callbacks used the real plan.

Acceptance Criteria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Candidates for Next Sprint
Development

No branches or pull requests

1 participant