Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure not to run centring between screening and full collection #483

Open
DominicOram opened this issue Sep 13, 2024 · 1 comment
Open

Comments

@DominicOram
Copy link
Contributor

Currently if screening comes back saying to do a full collection on the current pin then centring is run again. This is unnecessary and should not be done.

Note: This may now be easier solved by making a specific screening plan rather than changing GDA/hyperion interactions

Acceptance Criteria

  • Centring is not done again if a screening comes back as should be doing a full collection
@rtuck99 rtuck99 self-assigned this Sep 16, 2024
@DominicOram DominicOram self-assigned this Sep 16, 2024
@rtuck99 rtuck99 removed their assignment Sep 16, 2024
@DominicOram
Copy link
Contributor Author

Logic needs to be:

  • If sample is same as before do not robot load
  • If robot has loaded a new sample or chi has changed re-do centring

See code in prod for a pretty dumb way to do it. Ideally we would get richer info from agamemnon about whether we're doing a screening or a chi change etc. then we can have neat plans for each

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants