-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn rather than fail if the webcam is not found #488
Comments
I have a hotfix on the beamline that does this but it requires more investigation as to why we are failing at all. GDA reads from the same webpage and does not regularly fail to get an image. The only differences between how GDA does it and how we do it are:
The hotfix on the beamline now does not check for error codes and carries on anyway, we should keep an eye on it and see if there are cases where we get an error code but still get a valid image. In which case we should just ignore the error code (maybe logging a warning) |
Occasionally the webcam can become offline (see https://ispyb.diamond.ac.uk/samples/sid/5853099). Given that the webcam is only really for troubleshooting issues Hyperion should be happy without it so if it is offline we should just log a warning and continue.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: