Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide how turn on experimental features #494

Open
olliesilvester opened this issue Sep 16, 2024 · 0 comments · May be fixed by #496
Open

Decide how turn on experimental features #494

olliesilvester opened this issue Sep 16, 2024 · 0 comments · May be fixed by #496

Comments

@olliesilvester
Copy link
Contributor

olliesilvester commented Sep 16, 2024 •
edited
Loading

In config_server, we have a few parameters which default to True or False. These parameters can also be set in GDA and passed into Hyperion's parameter model. We should be clear about how they're set

I think that for now, if the GDA parameter for, eg, use_panda is set, then this value should be used. If it's not supplied, then the config server should be used

Acceptance Criteria

  • Above logic is implemented
@olliesilvester olliesilvester changed the title Tidy up use_panda parameter Tidy up config_server parameters Sep 16, 2024
@olliesilvester olliesilvester changed the title Tidy up config_server parameters Tidy up config_server feature parameters Sep 16, 2024
@olliesilvester olliesilvester changed the title Tidy up config_server feature parameters Decide how turn on experimental features Sep 16, 2024
@olliesilvester olliesilvester linked a pull request Sep 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only use config server if GDA didn't supply params DiamondLightSource/mx-bluesky
1 participant
@olliesilvester