Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(phpbb) banned users can login / change pages #22

Open
abma opened this issue Feb 15, 2017 · 3 comments
Open

(phpbb) banned users can login / change pages #22

abma opened this issue Feb 15, 2017 · 3 comments

Comments

@abma
Copy link

abma commented Feb 15, 2017

idk how to check the banned state but it seems the plugin doesn't check ban state of a user in phpbb.

@abma abma changed the title (phpbb) banned users can edit the wiki (phpbb) banned users can login / change pages Feb 15, 2017
@C4K3
Copy link
Contributor

C4K3 commented Feb 15, 2017

Correct it doesn't, it only checks whether the user is active or not, and whether the user is in the proper group.

We wouldn't be able to change it so banned users can't view the wiki, and it might be hard to check for banned emails/IPs, but we could probably make it check for banned users.

@JWPlatt
Copy link
Contributor

JWPlatt commented Feb 20, 2017

The banned users table (banlist) can be checked by user ID (ban_userid - indexed as ban_user:ban_userid + ban_exclude), email (ban_email), or IP (ban_ip). Need to consider users.user_id, users.user_email, banlist.ban_userid, banlist.ban_email, and banlist.ban_ip in the SELECT, given $username in getCanonicalName(). $username will be IP for anonymous users. IP can be wildcarded in banlist.ban_ip, so a little more effort there.

@C4K3
Copy link
Contributor

C4K3 commented Mar 20, 2017

phpbb/session.php has a method check_ban, we should probably just use that method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants