Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying babel config from addon #133

Open
anlumo opened this issue Oct 23, 2018 · 5 comments
Open

Allow specifying babel config from addon #133

anlumo opened this issue Oct 23, 2018 · 5 comments

Comments

@anlumo
Copy link

anlumo commented Oct 23, 2018

_babelTranspile in lib/service-worker-builder.js specifies its own babel config. Unfortunately, my configuration is very different (for example, I need the syntax-object-rest-spread plugin). I don't see a way to adjust this configuration from the outside.

@anlumo
Copy link
Author

anlumo commented Oct 23, 2018

Just discovered that there's the same issue with rollup.

@eshtadc
Copy link
Contributor

eshtadc commented Nov 6, 2018

Actually - it looks like the _babelTranspile only transpiles the trees for the service worker plugins and service worker files. The configuration set there doesn't apply to the application code.

@anlumo
Copy link
Author

anlumo commented Nov 6, 2018

I've made some commits in my fork that fixes the issues with es6: https://github.com/anlumo/ember-service-worker/commits/master

They're not ready for contributing upstream, but they do show where the screws have to be replaced. The broccoli-uglify-sourcemap update is pretty important.

@eshtadc
Copy link
Contributor

eshtadc commented Nov 6, 2018

@anlumo You should check the latest master - there are a bunch of dependency updates that were completed in the last few days. Would love to hear how this works for you as a beta prior to releasing a next version.

@eshtadc
Copy link
Contributor

eshtadc commented Dec 14, 2018

@anlumo Following up on this again. I'm still pretty sure that the transpile here shouldn't affect your application level files, but would love confirmation. Could you confirm and test with the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants