Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holistic approach to fetch settings #144

Open
eshtadc opened this issue Dec 14, 2018 · 0 comments
Open

Holistic approach to fetch settings #144

eshtadc opened this issue Dec 14, 2018 · 0 comments

Comments

@eshtadc
Copy link
Contributor

eshtadc commented Dec 14, 2018

Most SW plugins make fetch calls and there is a need to enable authorization to be sent. This seems like something that should be configured rather than defaulted, but it applies to many different plugins. Rather than having a configuration per plugin that has the application developer repeat, it may make sense to have some sort of fetch init configuration specified in the the overall service worker addon. In some ways I could also see this as an odd choice from a purist standpoint because it isn't used by the SW addon directly. The original PR that triggered this is DockYard/ember-service-worker-cache-fallback#9

Creating this issue as a place to discuss pros/cons....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant