Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embroider support #187

Open
simonihmig opened this issue Nov 17, 2020 · 4 comments
Open

Embroider support #187

simonihmig opened this issue Nov 17, 2020 · 4 comments

Comments

@simonihmig
Copy link
Contributor

This addon won't work in an app built with Embroider, as it uses the postprocessTree hook for type=all, which is not supported in Embroider unfortunately.

Any specific reason to use this hook vs. treeForPublic, which I think would also work here when you don't need access to the final compilation result, which is not the case here AFAICT?
@steveszc steveszc mentioned this issue Apr 2, 2021
Open
@simonihmig simonihmig mentioned this issue Apr 13, 2021
Merged
@sebastianhelbig
Copy link

Anyone working on this?

@bloemendal
Copy link

Does anyone have an answer for the treeForPublic question?

@st-h st-h mentioned this issue Feb 22, 2023
Open
@charlesfries
Copy link

Can we transfer this repo to adopted ember addons?

@mrloop
Copy link

mrloop commented Jun 20, 2024

There's a PR for this here #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mrloop @bloemendal @simonihmig @charlesfries @sebastianhelbig