Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to prevent unintentional rebuilds #88

Open
ghost opened this issue Sep 15, 2017 · 5 comments
Open

Add caching to prevent unintentional rebuilds #88

ghost opened this issue Sep 15, 2017 · 5 comments

Comments

@ghost
Copy link

ghost commented Sep 15, 2017

See: #86 (comment)
Also related: #84

@ghost ghost mentioned this issue Sep 15, 2017
@olegstepura
Copy link

Sorry to ping, but is any work planned on this?

@eshtadc
Copy link
Contributor

eshtadc commented Jul 11, 2019

Nothing has been started to my knowledge but this is still a problem and should be addressed. Care to take a stab at a PR?

@olegstepura
Copy link

Not sure I know this addon codebase that well to be honest. Also issue description lacks details of what is expected to be done and why/how this would help. I came back here (with some hope :) following a link in our codebase answering why we cannot have CSS hot reload and service workers together.

@jrjohnson
Copy link
Contributor

@olegstepura we've been happy using #84 (comment) to have both. I don't really want service worker running in development anyway so I've just added that to a .env file.

@eshtadc
Copy link
Contributor

eshtadc commented Jul 12, 2019

So if I read the PR comment linked above correctly, the inline strategy will cause the index.html file to be overwritten breaking hot reload. The suggestion is to only rewrite index.html when the strategy or contents of the registration script change to force a rewrite. Now that it's on my mind I'll do some research into a way to accomplish this. Suggestions welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants