Suggestion register after page loaded

[beatrizdemiguelperez]

On the service-worker-registration.js

Delay registration until after the page has loaded, to ensure that our precaching requests don't degrade the first visit experience.
See https://developers.google.com/web/fundamentals/instant-and-offline/service-worker/registration they recommend doing this so...

if ('serviceWorker' in navigator) {
  window.addEventListener('load', function() {
    navigator.serviceWorker.register('/service-worker.js');
  });
}

[ghost]

Ah great, will add this as a strategy when I have time :)

[simonihmig]

I like that approach! But, as the linked article suggests...

Similarly, if your web app uses a framework that performs additional setup after the page has loaded, look for a framework-specific event that signals when that work is done.

... shouldn't this be done even after Ember has booted and the first render has happened (e.g. scheduled afterRender in an initializer)?

[NullVoxPopuli]

if it's async, does it matter if ember has finished booting?