-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core ext javascript blocking time #60
Comments
As shown, there is a problem in core/index.js
The problem is, that this function calls itself with every logger instance. So it would be better to do the logger core/index.js:33 for (logger in ulog()) {
window.setTimeout(function updateLogger() {
ulog.ext(ulog(logger))
}, 0);
} As example with more than 20 |
Mmmm I think I like this idea! |
Ok so I did not merge this. Sorry. It's better to fix the real perf issue than to hide it behind setTimeout I think. I have some ideas on how to tackle it but it might make the API for mods (even) more messy.... Then I got a new job and got totally swamped with work and stopped working on this for a while. |
Ah yes. This is not pure, but there is an issue with the notify sometimes taking too long, so I tried to split up the work. Chrome complains sometimes about setTimeout handler taking too long to complete. This happens when it hovers around the 50ms mark.
Originally posted by @Download in #52 (comment)
The text was updated successfully, but these errors were encountered: