Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ulog doesn't work in Safari #63

Open
liborjelinek opened this issue Apr 16, 2021 · 4 comments
Open

Ulog doesn't work in Safari #63

liborjelinek opened this issue Apr 16, 2021 · 4 comments
Labels

Comments

@liborjelinek
Copy link

In Safari, webpage using ulog crash with SyntaxError: Invalid regular expression: invalid group specifier name error in console.

For example, in my case, the webapp will not render at all (web page is blank). It looks that it because ulog uses regex lookbehind not supported in Safari at all (even latest 14). It must be a long standing bug. I tried 1.5 year old versions with the same result.

I'm not able to tell you more. Because it makes our web app completely unusable for Mac users, we have to replace ulog with alternative. However, here are screenshots just before replacing ulog.

image

CleanShot 2021-04-16 at 10 35 38@2x

@Download
Copy link
Owner

Download commented May 5, 2021

Sorry for taking long to reply. I just got a new job and have been swamped with work.

I am unfortunately not able to easily test in Safari since I own no mac or iPhone.
If you can point me to a way to easily test this, I will definitely try to fix this.
If you are able to dig into this, I will definitely help you merge a PR to fix this.

I am guessing this error maybe actually comes from kurly which uses a regex to parse the output and format settings. I had to make a fix before because of another regex feature not supported by IE and Safari. But apparently this one is supported by IE but not Safari... So I never noticed...

@Download Download added the bug label May 5, 2021
@liborjelinek
Copy link
Author

I can't help you more I sent above. I don't understand how to know which file/line causes the error because Webpack magnled it.... But we can meet in Teams/whatever and you can try it on my desktop to decrypt the root cause.

@Download
Copy link
Owner

I don't understand how to know which file/line causes the error because Webpack magnled it....

You can (temporarily) disable minification:

webpack.config.js

module.exports = {
  // ...
  optimization: {
    minimize: false,
    minimizer: [
      new TerserPlugin({
        extractComments: false,
      }),
    ],
  },
}

But we can meet in Teams/whatever and you can try it on my desktop to decrypt the root cause.

That could also work. What timezone are you in?
I'm in Central European Timezone myself. With daylight savings.

@Download
Copy link
Owner

When you found the line, you could try hacking the bundle.js to see if you can fix it. That way you can quickly test changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants