Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much slower than url.parse for urls with query strings #15

Open
qzb opened this issue Apr 17, 2016 · 0 comments
Open

Much slower than url.parse for urls with query strings #15

qzb opened this issue Apr 17, 2016 · 0 comments

Comments

@qzb
Copy link
Contributor

qzb commented Apr 17, 2016

I've tested uriparser's performance across multiple versions of node. Unfortunately for this library, times have changed. When url has query string builtin url.parse is faster, much faster. For urls without query string uriparser still beats url.parse, but this is generally lightweight operation, so difference is rather small. Anyhow, I think there should be some disclaimer telling that uriparser should not be used with modern node.js versions.

I've been using script from my pull request (#14).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant