Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Make fails at discord-rpc module (linux) #675

Open
Seanofthedead2 opened this issue Jun 4, 2024 · 3 comments
Open

[Bug] Make fails at discord-rpc module (linux) #675

Seanofthedead2 opened this issue Jun 4, 2024 · 3 comments
Assignees
Labels

Comments

@Seanofthedead2
Copy link

Describe the bug
Final make step in instructions fails at the discord-rpc module. Seems like some sort of read-only member assignment.

To Reproduce
Steps to reproduce the behavior:
Clone the project using git and then run git submodule update --init --recursive to download the required submodules.
Install CMake
Check 'build.linux' for libraries to install
Run cmake -DCMAKE_BUILD_TYPE=Release . and then make from the root of the project

Expected behavior
Make build and binary

Screenshots
N/a, see attached txt file for full console log

Desktop (please complete the following information):

  • OS: Arch Linux
  • GPU: AMD 6600XT
  • CPU: Ryzen 5 5600X
  • Version: 0.5.0, fresh git clone

Additional context
Add any other context about the problem here.

Log file

In file included from /home/sean/git/unnamed-sdvx-clone/third_party/discord-rpc/src/serialization.h:15,
                 from /home/sean/git/unnamed-sdvx-clone/third_party/discord-rpc/src/rpc_connection.h:4,
                 from /home/sean/git/unnamed-sdvx-clone/third_party/discord-rpc/src/discord_rpc.cpp:6:
/home/sean/git/unnamed-sdvx-clone/third_party/discord-rpc/thirdparty/rapidjson-1.1.0/include/rapidjson/document.h: In member function ‘rapidjson::GenericStringRef<CharType>& rapidjson::GenericStringRef<CharType>::operator=(const rapidjson::GenericStringRef<CharType>&)’:
/home/sean/git/unnamed-sdvx-clone/third_party/discord-rpc/thirdparty/rapidjson-1.1.0/include/rapidjson/document.h:319:82: error: assignment of read-only member ‘rapidjson::GenericStringRef<CharType>::length’
  319 |     GenericStringRef& operator=(const GenericStringRef& rhs) { s = rhs.s; length = rhs.length; }
      |                                                                           ~~~~~~~^~~~~~~~~~~~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-global-constructors’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-exit-time-destructors’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-covered-switch-default’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-c++98-compat-pedantic’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-c++98-compat’ may have been intended to silence earlier diagnostics
make[2]: *** [third_party/discord-rpc/src/CMakeFiles/discord-rpc.dir/build.make:76: third_party/discord-rpc/src/CMakeFiles/discord-rpc.dir/discord_rpc.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:681: third_party/discord-rpc/src/CMakeFiles/discord-rpc.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

See full console log attached, there were some failed curls early in the cmake process
usc_error.txt

@Seanofthedead2
Copy link
Author

Seanofthedead2 commented Jun 4, 2024

P.S. What exactly does this module do? I do already have discord and it was running during the build process. If this module can be skipped, where do I need to remove/comment it?

@Hinara
Copy link

Hinara commented Jun 7, 2024

Seems to be related to new gcc version
Tencent/rapidjson#2277
Problem is that is a subdependency of discord-rpc being out of date, but as discord-rpc is archived and this issue might not be resolvable without applying a patch to some file of discord-rpc

@M1ssing0
Copy link

little late to this but you can simply workaround this by replacing the build of rapidjson included with discord-rpc with the one from the source of Tencent/rapidjson to .../unnamed-sdvx-clone/third_party/discord-rpc/thirdparty/rapidjson-1.1.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants