-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Language selector #162
Comments
👋 Thanks for reporting! We will get back to you soon about this issue. |
I'm not gonna do this right away as its not that important if the only translation that works well is English but as soon as 2 or more extra languages have 50% or more worked on this i will look into adding it. with only having 1 extra language at 12% complete its kind of pointless adding a language selector. |
That's fair. Can imagine there's boatloads of more important stuff, just wanted to put this out there. I'll see to it that the Dutch translation will be up to date. |
ya if |
Hence why I figured it might be a nice addition seeing you already implemented it once ;) Makes absolute sense to not add anything that isn't being actively updated. |
Dutch should be fairly sanitized now on Crowdin. |
I have added you as a proofreader. Please accept the changes so I can create a pull request and add them. After that, I'll proceed with adding this feature. |
#168 is ready for when you are done |
@Sarsharses almost done. |
Dutch is 100%-ed now :) |
Thanks this isn's the spot to ask this but do other options like the select app for gestures work in non english? |
I'll get back to you when I finish work and can properly do some tests. |
All done #b4e5687 |
Looks great! Only found one thing that doesn't work for me now and that is that the 'Easy Launcher Actions Service' needed for screen locking, power dialog and recent app showing can not be enabled but this might be something in my device settings. |
Ya you may need to go into app settings and force enable that as depending how it is installed some times android 13+ blocks it. |
Right, might be good to try that then. Ran into a bug just now though where the gestures seem to crash whenever one of them has been performed. Was there any specific reason you asked about the open app one? The nightly build doesn't seem to have this issue. If you want I can try to find out how to reproduce this tomorrow. |
Did this only start to happen since 0.2.7 and after if so then I know why and I'll fix it asap |
Maybe a fresh install is what fixed it as the nightly should be the same. I didn't seem to have any crashes.
If you can email the crash report with the data filled out I can read the logs and find out why. |
No clue, only noticed you were working on this because I saw you set the mLauncher repo to read only and this was already at 0.2.7 so would have to backtrack as well. |
The nightly does have the same issue, so it probably won't be fixed by a fresh install.
It softcrashes so there is no log I suppose? |
I will have a look tomorrow at some of these issues as I think I know how to fix them pretty quickly. |
@Sarsharses #05133510 has fixed the issue within that screenshot |
This doesn't seem to have fixed the issue so I'll need to take a deeper look into it more and see why that stopped working right after I did the commit and did a release. |
G'morning, the language selector looks pretty neat, however it doesn't actually change the language when the settings are updated. Tried to see if maybe it'd work if my systemlanguage was set to English but that didn't help. |
It did work but I guess playing about with other stuff broke it along with gestures I'll look at a fix soon |
Checklist
Feature description
Hiya, great work so far!
Would like to suggest adding a dropdown or some sort of other selection menu for switching the displayed language of the launcher settings.
I, for example, don't necessarily like to use Dutch for my primary interface when I unlock my phone, but I need several other apps that don't offer on the fly switching in my native language. Other people might possibly enjoy the same functionality.
This in turn would make it a lot easier to contribute to translations without having to change device language everytime to scout where the next string is located.
Additional information
No response
Terms and Conditions
Donation Name
sarsharses
The text was updated successfully, but these errors were encountered: