Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Language selector #162

Closed
9 tasks done
Sarsharses opened this issue Nov 24, 2024 · 26 comments
Closed
9 tasks done

[Enhancement] Language selector #162

Sarsharses opened this issue Nov 24, 2024 · 26 comments
Assignees
Labels
Status: Done This has been compleated. Type: Enhancement New feature or request

Comments

@Sarsharses
Copy link
Contributor

Checklist

  • I will make sure to have the issue written in English with an English title.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have already checked the WIKI pages and made sure that the feature isn't already exist.
  • I've verified that this issue hasn't been addressed in the changelogs.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I optionally donated to support the EasyLauncher mission.

Feature description

Hiya, great work so far!
Would like to suggest adding a dropdown or some sort of other selection menu for switching the displayed language of the launcher settings.

I, for example, don't necessarily like to use Dutch for my primary interface when I unlock my phone, but I need several other apps that don't offer on the fly switching in my native language. Other people might possibly enjoy the same functionality.

This in turn would make it a lot easier to contribute to translations without having to change device language everytime to scout where the next string is located.

Additional information

No response

Terms and Conditions

  • I have read all the rules above and filled in the requiered fields to the best of my ability.
  • I accept that if I fail to follow the rules listed above that i will be blocked from interactions with this project.

Donation Name

sarsharses

@Sarsharses Sarsharses added the Type: Enhancement New feature or request label Nov 24, 2024
Copy link
Contributor

👋 Thanks for reporting!

We will get back to you soon about this issue.

@HeCodes2Much HeCodes2Much added the Status: Todo Things we need to do. label Nov 24, 2024
@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Nov 24, 2024

I'm not gonna do this right away as its not that important if the only translation that works well is English but as soon as 2 or more extra languages have 50% or more worked on this i will look into adding it.

with only having 1 extra language at 12% complete its kind of pointless adding a language selector.

@Sarsharses
Copy link
Contributor Author

That's fair. Can imagine there's boatloads of more important stuff, just wanted to put this out there. I'll see to it that the Dutch translation will be up to date.

@HeCodes2Much
Copy link
Contributor

ya if Shiinrow had the dutch language at at least 75% then i could see the point in adding it but i will only add languages as they reach the 75% mark. its not too had to do this as i did it for mLauncher before so i can just use the same code but make it work for the style of EasyLauncher.

@Sarsharses
Copy link
Contributor Author

Hence why I figured it might be a nice addition seeing you already implemented it once ;) Makes absolute sense to not add anything that isn't being actively updated.

@Sarsharses
Copy link
Contributor Author

Dutch should be fairly sanitized now on Crowdin.
I'll keep an eye out for missing or strange translations.

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Nov 24, 2024

Dutch should be fairly sanitized now on Crowdin. I'll keep an eye out for missing or strange translations.

I have added you as a proofreader. Please accept the changes so I can create a pull request and add them. After that, I'll proceed with adding this feature.

@HeCodes2Much HeCodes2Much added Status: Work In Progress This is currently being worked on and removed Status: Todo Things we need to do. labels Nov 24, 2024
@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Nov 24, 2024

#168 is ready for when you are done

@HeCodes2Much
Copy link
Contributor

@Sarsharses almost done.

@Sarsharses
Copy link
Contributor Author

Dutch is 100%-ed now :)

@HeCodes2Much
Copy link
Contributor

Dutch is 100%-ed now :)

Thanks

this isn's the spot to ask this but do other options like the select app for gestures work in non english?

@Sarsharses
Copy link
Contributor Author

I'll get back to you when I finish work and can properly do some tests.

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Nov 25, 2024

New Project

All done #b4e5687

@HeCodes2Much HeCodes2Much added Status: Done This has been compleated. and removed Status: Work In Progress This is currently being worked on labels Nov 25, 2024
@Sarsharses
Copy link
Contributor Author

Looks great!

Only found one thing that doesn't work for me now and that is that the 'Easy Launcher Actions Service' needed for screen locking, power dialog and recent app showing can not be enabled but this might be something in my device settings.

@HeCodes2Much
Copy link
Contributor

Looks great!

Only found one thing that doesn't work for me now and that is that the 'Easy Launcher Actions Service' needed for screen locking, power dialog and recent app showing can not be enabled but this might be something in my device settings.

Ya you may need to go into app settings and force enable that as depending how it is installed some times android 13+ blocks it.

@Sarsharses
Copy link
Contributor Author

Sarsharses commented Nov 25, 2024

Right, might be good to try that then.

Ran into a bug just now though where the gestures seem to crash whenever one of them has been performed. Was there any specific reason you asked about the open app one?

The nightly build doesn't seem to have this issue. If you want I can try to find out how to reproduce this tomorrow.

@Sarsharses
Copy link
Contributor Author

Alright, it occurs within the nightly as well. Whenever the applist is aligned to the any side the area to the other side bugs out the gestures. Only place where they register correctly is in the empty space below the applist.

Added screenshot for clarification. If you need this in a seperate bugreport let me know
Screenshot_2024-11-25-22-54-27-55_1d151929efb2ddc7073e99a7f966a46b

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Nov 25, 2024

Alright, it occurs within the nightly as well. Whenever the applist is aligned to the any side the area to the other side bugs out the gestures. Only place where they register correctly is in the empty space below the applist.

Did this only start to happen since 0.2.7 and after if so then I know why and I'll fix it asap

@HeCodes2Much
Copy link
Contributor

HeCodes2Much commented Nov 25, 2024

The nightly build doesn't seem to have this issue. If you want I can try to find out how to reproduce this tomorrow.

Maybe a fresh install is what fixed it as the nightly should be the same. I didn't seem to have any crashes.

Ran into a bug just now though where the gestures seem to crash whenever one of them has been performed.

If you can email the crash report with the data filled out I can read the logs and find out why.

@Sarsharses
Copy link
Contributor Author

No clue, only noticed you were working on this because I saw you set the mLauncher repo to read only and this was already at 0.2.7 so would have to backtrack as well.

@Sarsharses
Copy link
Contributor Author

Sarsharses commented Nov 25, 2024

Maybe a fresh install is what fixed it as the nightly should be the same. I didn't seem to have any crashes.

The nightly does have the same issue, so it probably won't be fixed by a fresh install.

If you can email the crash report with the data filled out I can read the logs and find out why.

It softcrashes so there is no log I suppose?

@HeCodes2Much
Copy link
Contributor

I will have a look tomorrow at some of these issues as I think I know how to fix them pretty quickly.

@HeCodes2Much
Copy link
Contributor

@Sarsharses #05133510 has fixed the issue within that screenshot

@HeCodes2Much
Copy link
Contributor

@Sarsharses #05133510 has fixed the issue within that screenshot

This doesn't seem to have fixed the issue so I'll need to take a deeper look into it more and see why that stopped working right after I did the commit and did a release.

@Sarsharses
Copy link
Contributor Author

G'morning, the language selector looks pretty neat, however it doesn't actually change the language when the settings are updated. Tried to see if maybe it'd work if my systemlanguage was set to English but that didn't help.

@HeCodes2Much
Copy link
Contributor

It did work but I guess playing about with other stuff broke it along with gestures I'll look at a fix soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This has been compleated. Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants