-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further enhance 0.5 migration scalafix #237
Conversation
@CJSmith-0141 Do you have any suggestions here? |
The advice from this post by @/bjaglin on the scalameta discord is:
So I think that you're on the right track with your commented out code here Maybe a strategy like you did with
|
I took a shot at it in #238 targeting this branch. |
@CJSmith-0141 I incorporated your suggestion from #238 and took it a step further. I think this is pretty close to being ready to merge and release; what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for putting time into this @bpholt
I think this covers the migration cases I was looking for, with the exception that I haven't been able to figure out how to globally replace
tagChunkSize
withChunkSize
and also have it work inline in aencrypt
method call without publishing two separate rules.Unless anyone has any great ideas, on Monday I'll probably start working on a second rule and documentation stating "run the
tagChunkSize
→ChunkSize
rule first" and then the more universal rule second.