Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IO changes dtypes between rhist and h, leading to fails #2898

Closed
mahf708 opened this issue Jul 11, 2024 · 0 comments · Fixed by #2902
Closed

IO changes dtypes between rhist and h, leading to fails #2898

mahf708 opened this issue Jul 11, 2024 · 0 comments · Fixed by #2902
Labels
bug Something isn't working I/O priority:high severe bug

Comments

@mahf708
Copy link
Contributor

mahf708 commented Jul 11, 2024

This issue was encountered by @brhillman. Reporting the details here for better provenance.

  699: 
  699:  FAIL:
  699: var->dtype==refine_dtype(dtype)
  699: /autofs/nccs-svm1_home1/brhillman/codes/scream/branches/decadal-production-run6/components/eamxx/src/share/io/scream_scorpio_interface.cpp:997
  699: Error! Attempt to redefine variable with different data type.
  699:  - filename : output.scream.decadal.monthlyAVG_ne30pg2.AVERAGE.nmonths_x1.1994-10-01-00000.nc
  699:  - varname  : avg_count_ncol
  699:  - old dtype: float
  699:  - new dtype: double
  699:

Some notes from internal messaging:

  • The problem stems from the fact that the attr in question was written as float in the ACTUAL output, but was written as DOUBLE in the rhist files

  • In all rhist files (there are 4 of them) it is always double, I have no clue how it was written as FLOAT in the output

  • This commit is v sus: 29dd63b

  • Setting force_new_file: true (default false) seems to overcome this issue

highly likely xref #2890 #2892
AaronDonahue added a commit that referenced this issue Jul 11, 2024
@AaronDonahue
Fix bug in io with registering avg_cnt vars in Append mode.
b019f2e 
This commit addresses a bug where average count tracking variables
may be registered again when a file is in Append mode.  There is logic
in the registration of typical output variables that was missing for
average count variables.

Addresses #2898
@AaronDonahue AaronDonahue mentioned this issue Jul 11, 2024
Merged
@mahf708 mahf708 linked a pull request Jul 12, 2024 that will close this issue
Fix bug in io with registering avg_cnt vars in Append mode. #2902
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working I/O priority:high severe bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug in io with registering avg_cnt vars in Append mode. E3SM-Project/scream
1 participant
@mahf708