New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about environment validation #135

Open

wesdeveloper opened this issue Jul 2, 2019 · 2 comments

wesdeveloper commented Jul 2, 2019

nodejs-api-boilerplate/src/config/middlewares.js

Line 29 in 0dcea20

if (isDev && !isTest) {

Why would you verify if its isDev and not isTest simultaneously? To me, that makes no sense because if isDev is true, isTest will never be.

Owner

EQuimper commented Jan 17, 2020

Umh I dont remember why I did that. But yes good catch

Owner

EQuimper commented Jun 16, 2020

@wesdeveloper I think this was just to make sure it is in prod.

So if dev is false this can be test or prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment