Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): support for 1.18.2 #25

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SettingDust
Copy link
Contributor

@SettingDust SettingDust commented Jun 15, 2022

Context: Stuck at FabricMC/fabric-loader#682

@SettingDust SettingDust changed the title feat(deps): support for 1.18.2 [WIP] feat(deps): support for 1.18.2 Jun 16, 2022
@SettingDust SettingDust changed the title [WIP] feat(deps): support for 1.18.2 feat(deps): support for 1.18.2 Jul 7, 2023
@SettingDust
Copy link
Contributor Author

@EZForever After test. It works in 1.18.2 prod with fabric loader 0.14.21
CC. @Norbiros

@SettingDust
Copy link
Contributor Author

Need explain #28

@EZForever
Copy link
Owner

@SettingDust

Wow. Did you mean it's working outside of the dev environment? I can't believe it's still possible. I'll review and try your code later when I got some spare time.

#28 is answered.

@SettingDust
Copy link
Contributor Author

SettingDust commented Jul 7, 2023

@SettingDust

Wow. Did you mean it's working outside of the dev environment? I can't believe it's still possible. I'll review and try your code later when I got some spare time.

#28 is answered.

  • I using the ModInjector directly and it's works. - The Why the mod injector is loaded by reflect? #28 for. I can't ensure if it will causing issue
  • I using reflect to construct ModScan and compute.
  • I change the ModCandidateFinder to ClasspathModCandidateFinder that is public and shouldn't have side effect that is override
    It's simple and works. I can't believe why can I haven't noticed the method in the past XD

@EZForever
Copy link
Owner

Amazing, though I have to try it myself and see why on earth is that possible.

btw, I've noticed that Modsmod is still updating. What's their approach on the issues we're facing here?

@SettingDust
Copy link
Contributor Author

They needn't find mods. Just generate it.

@Norbiros
Copy link

Norbiros commented Jul 7, 2023

Good job!

@SettingDust
Copy link
Contributor Author

BTW, I gonna to refactor with yacl and support quilt for 1.19.2.

@SettingDust
Copy link
Contributor Author

BTW, I gonna to refactor with yacl and support quilt for 1.19.2.

Finally, start a new project for that https://github.com/SettingDust/ModSets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants