Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWM Concurrency #401

Open
sjpark608 opened this issue Oct 19, 2023 · 0 comments · Fixed by #402
Open

PWM Concurrency #401

sjpark608 opened this issue Oct 19, 2023 · 0 comments · Fixed by #402
Assignees
@sjpark608
Labels
PWM

Comments

@sjpark608
Copy link
Collaborator

related to #400

We've discussed what'd be the expected behaviour of reading/writing closed file. The program should bubble up the exception thrown when read/write the closed file to notify there's a thread closed the PWM file (intentionally and unintentionally).

need to implement try, except finally structure in set_config to bubble up the exception with proper exception
@sjpark608 sjpark608 added the PWM label Oct 19, 2023
@sjpark608 sjpark608 self-assigned this Oct 19, 2023
This was referenced Oct 19, 2023
Merged
Merged
@sjpark608 sjpark608 linked a pull request Oct 20, 2023 that will close this issue
Dev pwm #401 #402
Merged
sjpark608 added a commit that referenced this issue Oct 20, 2023
@sjpark608
Dev pwm #401 (#402)
0cdbe08 
* added open device check

every get/set function checks whether the device is open
unittest pylint passed, integration test required

* integration test in progress

* init throws an file not found error when called concurrently with close function

* Update test_edgepi_pwm_concurrency.py

pylint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjpark608 sjpark608

Labels
PWM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev pwm #401 EdgePi-Cloud/edgepi-python-sdk
1 participant
@sjpark608