Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type discrepancy for duty_cycle in pwm module #404

Open
josiah-tesfu opened this issue Nov 7, 2023 · 0 comments
Open

Type discrepancy for duty_cycle in pwm module #404

josiah-tesfu opened this issue Nov 7, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation priority/P3 PWM

Comments

@josiah-tesfu
Copy link

josiah-tesfu commented Nov 7, 2023

In edgepi_pwm.py, In set_config, duty_cycle and frequency should both be float. This should be reflected in both the type hints and the docstring. Currently, the type hints have duty_cycle as an int and frequency as a float, while the docstring has both as an int. The docstring should also change the parameter bounds from 0-100 to 0-1 to be consistent with _set_duty_cycle.

@josiah-tesfu josiah-tesfu added documentation Improvements or additions to documentation PWM labels Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority/P3 PWM
Projects
None yet
Development

No branches or pull requests

3 participants