[BUG] CSS regression

[peterstadler]

Describe the problem

When reviewing the PR #445 with the clarinet quintet data it occurred to me that some CSS had changed. At first I blamed this PR but then I realized that it must have been introduced at some earlier stage since #444 also showed this behavior.

To Reproduce

Steps to reproduce the behavior:

1. build Edirom Online from dev
2. load clarinet data from pipeline build at https://git.uni-paderborn.de/wega/klarinettenquintett-edirom
3. load both xar packages into a fresh existdb
4. launch Edirom Online
5. open "Editionsbericht"

Expected behavior

running with v1.0.0-beta.5

how it looks like

running with current dev

[bwbohl]

maybe it’s connected to the update of the TEI Stylesheets (#371 )?

[bwbohl]

Unfortunately I cannot reproduce this at the moment, all looks fine in my instance…

[daniel-jettka]

I can confirm the bug.

[bwbohl]

Meanwhile I can confirm this, too…[EDIT]
No, I can’t…

I looked only at the heading sizes, not at the indentation!

We should do a proper cleanup of resources/css/todo.css
Having it at all was a bad idea in the first place; it came into existence for quick css development but the rules defines should always be properly incorporated in the SASS definitions. Moreover, with the additional_css_path preference property it is easy to temporarily add any css file in the database for such purposes.

[peterstadler]

There's a similar CSS issue in the Search window, see #463 (comment)

[daniel-jettka]

I tried to fix the indentation. @peterstadler Could you check? I mean the heading looks different too... Is this a bigger thing or enough for now to change indentation?

[peterstadler]

I think we need to investigate a bit more regarding the root cause of this change. I just compared the CSS files from the old and the current version: the old one loads a file /apps/weber-klarinettenquintett-eol-emeritus/resources/css/main.css, i.e. from the data collection, not from the Edirom Online collection. Hence, it seems to me that the loading of project specific CSS files fails somehow?!

[roewenstrunk]

In index.xql line 23

Edirom-Online/add/index.xql

Line 23 in fc3baf8

declare variable $editionUri := if($edition) then edition:findEdition($edition) else();

there should not be an if clause. You will always want to find the editionURI.

Then the project specific css is loaded again.