Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insertions get shuffled for "Instruments/Performers selection" on details-expression.xml #128

Open
peterstadler opened this issue Nov 4, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@peterstadler
Copy link
Member

Adding performers will always add at the second position:

Bildschirmfoto 2022-11-04 um 11 56 09

test file available from #126

@peterstadler peterstadler added the bug Something isn't working label Nov 4, 2022
@peterstadler peterstadler added this to the Release 2.0 milestone Nov 7, 2022
@gucl-mu
Copy link
Collaborator

gucl-mu commented Dec 12, 2022

So the crucial point seems to me to be this sentence in the details-expression.xml:

the reference to the corresponding top level instrumentation is provided by the n attribute

The @n are not created when I enter the instruments. When I add them manually in the file, the click boxes behave correctly. The top-level instrumentation should then look like this:

<perfRes codedval="va" count="1" solo="false" auth="MARC" auth.uri="https://www.loc.gov/standards/valuelist/marcmusperf.html" xml:id="perfRes_6ad0d45f" xml:lang="it" n="1">S.</perfRes>

Since the instruments/performers should all be specified at top-level anyway, I would rather ignore the wrong alphabetical order in this error message ;) Why @n are not created correctly, I have not found in a hurry.

@dikastes
Copy link
Collaborator

The problem seems to have been solved. Instruments/performers can be inserted at any place. However, @n is still not created. Should we still close the issue?

@peterstadler
Copy link
Member Author

How to reproduce (with the example file " Hosianna dem Sohne David"):

  1. select music tab
  2. click on any component (e.g. "Chor") to edit
  3. click any of the greyed out checkboxes under "Instruments/Performers selection"

Desired functionality:

  • checked items are added at the end of the list
  • arrow buttons are added to enable moving of items
  • every item should only be selectable once

@peterstadler peterstadler removed this from the Release 2.0 milestone Jan 17, 2024
@peterprovaznik
Copy link
Collaborator

peterprovaznik commented Jan 17, 2024

  • arrow buttons are added to enable moving of items

Alternatively, since it's a subset anyway, maybe the sorting order from the ensemble could be used, which would not require so many changes/additions in the UI? @gucl-mu, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants