Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming heat curve fieldnames to reduce confusion... #492

Closed
stumbaumr opened this issue Jun 10, 2024 · 3 comments
Closed

Renaming heat curve fieldnames to reduce confusion... #492

stumbaumr opened this issue Jun 10, 2024 · 3 comments
Labels

Comments

@stumbaumr
Copy link

Writing and debugging rules I get again and again confused...
"Is high the target or outdoor temperature again?"

Maybe this happens also to other people here - use that thumbs up button down below!

Proposal:
Rename fields to

TOP29	Z1_Heat_Curve_Left_Target_Temp		40	°C
TOP30	Z1_Heat_Curve_Right_Target_Temp		32	°C
TOP31	Z1_Heat_Curve_Right_Outside_Temp	12	°C
TOP32	Z1_Heat_Curve_Left_Outside_Temp		-10	°C

Maybe that helps - if you don't like that idea use the thumbs down button below...

@edterbak
Copy link

Hi

This is the default:
TOP29 | Z1_Heat_Curve_Target_High_Temp = Water temperature, high value
TOP30 | Z1_Heat_Curve_Target_Low_Temp = Water temperature, low value
TOP31 | Z1_Heat_Curve_Outside_High_Temp = Outside temperature, high value
TOP32 | Z1_Heat_Curve_Outside_Low_Temp = Outside temperature, low value

image

If you think about what happens, it kind of sounds logical as it is:

  • The lowest outside temperature will result in the highest water temperature
  • The highes outside temperature will result in the lowest water temperature

I find current situation and your suggestion are both equally fuzzy / difficult. They both require a good 2nd look. I think in this case it is maybe better to increase the documentation.

Im not in favor of renaming mqtt topics for only estetic purpose. :) This can give a lot of extra work for others. (I am a victim in this case) But, If it truely has significant benefits it might be worth the effort IMHO. But.. in this case I do not see it that obviously.

Just my thoughts about it :)

@geduxas
Copy link
Contributor

geduxas commented Jun 14, 2024

I personally prefer to use terms or shorts as used in service manual, Outside High/Water Low, Outside Low/Water Hi (O_Hi/W_Lo, O_Lo/W_Hi)

Copy link

github-actions bot commented Oct 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants