Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output pay and xpay equal in listpays/listsendpays but still not in command return #7955

Open
hMsats opened this issue Dec 18, 2024 · 3 comments

Comments

@hMsats
Copy link
Contributor

hMsats commented Dec 18, 2024

v24.11-18-g2c8d9d0

command output pay is the same independent of xpay-handle-pay except for the order of the json (personally I would prefer the same order)

Bash-shell

lightning-cli pay lnbc40n1pnkxz38sp50myrs0ue4vxlfstq8ha3y77qz3kh7qqr34xkz5uglsxjzmtnyv2qpp5advct7hs82ur8m972v9qd0cxfne6qft3uclgj6dm0fn5a095chyqdqydp5qxqyjw5qcqpjrzjqtc63jrkql6ptj8j9sq9jvqzwav5rh4y3p5uugcfdte8kr8aes9kjrrqnqqq90qqqqqqqqqqqqqqraqqjq9qxpqysgqduu3e24kt3uwh00nzkc7q38x65e9nvlt2k6gvrqyuvern0d2tgg300wjvfx4jnkk32jfze56y2ut8evg4k7xqwwqpqc89qfwej79mkcqrxcaej
{
   "destination": "031979fe6ce0e69ece6d99a4bc4a7b30ed22a8cb8703dd7dd2dfaf619e07127e0b",
   "payment_hash": "eb5985faf03ab833ecbe530a06bf064cf3a02571e63e8969bb7a674ebcb4c5c8",
   "created_at": 1734543925.248515832,
   "parts": 1,
   "amount_msat": 4000,
   "amount_sent_msat": 4000,
   "payment_preimage": "3da07eb4857e119009df524d572ed39d685ace5faba6ed8e4f1bc80679086d04",
   "status": "complete"
}
lightning-cli xpay lnbc40n1pnkxzjysp57fmhsw0450gaxsa3yc4qkranr3ffarvywe2xg927hy2k22cwxkwqpp5mf0fh6vmce3cugae25837e0j3em4g0h4yad5lq4j4wegqtudsx0qdq9dp5ryxqyjw5qcqpjrzjqtc63jrkql6ptj8j9sq9jvqzwav5rh4y3p5uugcfdte8kr8aes9kjrrqnqqq90qqqqqqqqqqqqqqraqqjq9qxpqysgqc2gvra8a7xaw84ft493vacyll0tql45yrk790vu4vg35zz8jqlcqfn306jxjuhw7t70effcq8xwxgnl8gg50xl5pf7v5u6fkd43l5zgqpejfu6
# ->031979fe6ce0e69ece6d99a4bc4a7b30ed22a8cb8703dd7dd2dfaf619e07127e0b: Success: preimage=3623c369479e516fb00c40a428239ac67355bc536ebaae5c5076bc1e6655512b
{
   "payment_preimage": "3623c369479e516fb00c40a428239ac67355bc536ebaae5c5076bc1e6655512b",
   "amount_msat": 4000,
   "amount_sent_msat": 4000,
   "failed_parts": 0,
   "successful_parts": 1
}
@hMsats hMsats changed the title Output pay and xpay equal in listpays/listsendpays but not in command return Output pay and xpay equal in listpays/listsendpays but still not in command return Dec 18, 2024
@Lagrang3
Copy link
Collaborator

I think @rustyrussell wants the output of xpay to be this way. I am not sure why.

@Lagrang3
Copy link
Collaborator

You could try asking on discord or during the open meeting.

@hMsats
Copy link
Contributor Author

hMsats commented Dec 20, 2024

Now that I can use pay as xpay, I care less about it. Rusty can decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants