Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSD sed is angered by doc/Makefile #7957

Open
grubles opened this issue Dec 19, 2024 · 0 comments
Open

BSD sed is angered by doc/Makefile #7957

grubles opened this issue Dec 19, 2024 · 0 comments

Comments

@grubles
Copy link
Contributor

grubles commented Dec 19, 2024

$ gmake

...

PYTHONPATH=contrib/msggen python3 contrib/msggen/msggen/__main__.py bundle doc/schemas                                                                                                                             
Combining schemas from /home/user/builds/lightning/doc/schemas into /home/user/builds/lightning/contrib/msggen/msggen/schema.json                                                                                  
Created /home/user/builds/lightning/contrib/msggen/msggen/schema.json from 2 files                                                                                                                                 
msggen cln-grpc/proto/node.proto                                                                                                                                                                                   
Documentation version updated to v24.11.1                                                                
sed: 3: "                                                                                                
    :a;N;$!ba;                                                                                           
    s#\ ...": RE error: trailing backslash (\)                                                           
sed: 3: "                                                                                                
    :a;N;$!ba;                                                                                           
    s#\ ...": RE error: trailing backslash (\)                                                           
sed: 3: "                                                                                                
    :a;N;$!ba;                                                                                           
    s#\ ...": RE error: trailing backslash (\)                                                           
sed: 3: "                                                                                                
    :a;N;$!ba;                                                                                           
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                           
    :a;N;$!ba;     
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                           
    :a;N;$!ba;        
    s#\ ...": RE error: trailing backslash (\)
sed: 3: "                                           
    :a;N;$!ba;         
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                           
    :a;N;$!ba;     
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                           
    :a;N;$!ba;           
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                           
    :a;N;$!ba;                                      
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                           
    :a;N;$!ba;                                      
    s#\ ...": RE error: trailing backslash (\)      
tail: stdout: Broken pipe                           
sed: 3: "                                           
    :a;N;$!ba;                                      
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                           
    :a;N;$!ba;  
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                           
    :a;N;$!ba;                                      
    s#\ ...": RE error: trailing backslash (\)      
sed: 3: "                                                       

...

It seems like for portability purposes, we need sed -E?

     -E      Interpret regular expressions as extended (modern) regular
             expressions rather than basic regular expressions (BRE's).  The
             re_format(7) manual page fully describes both formats.

GNU sed also suggests -E:

       -E, -r, --regexp-extended

              use extended regular expressions in the script (for portability use POSIX -E).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant