Makefile: clean up install path handling. #7531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
simplify-install-path
branch
2 times, most recently
from
5195b9e
to
cba011f
Compare
We had some weird code to try to do relative paths. Instead, use absolute ones and keep life simple. Also rename "daemon_dir" to the clearer "subdaemon_dir" as that's what it's used for. We now need special magic to do "installcheck", which is a bit awkward, but at least it's contained. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
simplify-install-path
branch
from
cba011f
to
7b4ec5e
Compare
niftynei
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some weird code to try to do relative paths. Instead, use absolute ones and keep life simple. Also rename "daemon_dir" to the clearer "subdaemon_dir" as that's what it's used for.
This might help #7511 (comment)