-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add pay test over unannounced channels #7844
tests: add pay test over unannounced channels #7844
Conversation
29266fd
to
aa7a2a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment, otherwise looks good to me
Concept ACK aa7a2a3
c0a99a2
to
f3c98b7
Compare
The test was flaky |
f3c98b7
to
9b3c143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just rember that pay si returning the status too, so probably there is a clean way to check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the floppy review, adding another consideration
42d56b4
to
7971199
Compare
This test fails with cln v24.08.2. Add this test, so it doesn't happen again. Changelog-None
7971199
to
abd2201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK abd2201
a90d9c9
into
ElementsProject:master
This test fails with cln v24.08.2. Add this test, so it doesn't happen again.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: