Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix and improve tracing in CI #7847

Closed
wants to merge 7 commits into from
Closed

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Nov 20, 2024

Looks like I missed one mismatched span pointer. To avoid this going
forward we also enable systemtap-sdt-dev on all builds on CI, and in
reprobuilds, because we want operators to have the option of just
starting to trace.

Added @ShahanaFarooqui as reviewer since she revisited the reprobuild
recently, and we should likely discuss if tracing enabled everywhere
is as desirable as I think :-)

Closes #7843

I also added the `systemtap-usdt-dev` dependency so the tracing
functionality gets built into all versions. It's very lightweight and
intended to be enabled in the background everywhere. The configuration
without the tracing is just a fallback.

Changelog-None Not directly visible to users unless they use CI builds
Changelog-Changed release: Releases are now compiled with user-defined tracepoints enabled.
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack (once CI sorted), but please stop printing every trace to stderr?

Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing systemtap-sdt-dev in contrib/reprobuild/Dockerfile.focal and contrib/reprobuild/Dockerfile.jammy results in multiple 'unmet dependencies' errors.

Can we also confirm if some of these Dockerfiles are even actively being used? For instance, contrib/docker/Dockerfile.builder (using Ubuntu 16.04) throws an 'Unable to locate package lowdown' error, and contrib/docker/Dockerfile.tester (using Ubuntu 22.04) throws an 'Unable to locate package postgresql-10' error. Both of these errors occur even without installing the new library.

I am still running test script for ./Dockerfile's new install. I will update once it is finished.

@cdecker cdecker marked this pull request as draft November 21, 2024 13:42
@cdecker
Copy link
Member Author

cdecker commented Nov 21, 2024

Turns out I need a couple more iterations, I'm hoping to have a durable fix for this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash: trace_span_tag: Assertion `span' failed.
3 participants