-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix and improve tracing in CI #7847
Conversation
I also added the `systemtap-usdt-dev` dependency so the tracing functionality gets built into all versions. It's very lightweight and intended to be enabled in the background everywhere. The configuration without the tracing is just a fallback. Changelog-None Not directly visible to users unless they use CI builds
Changelog-Changed release: Releases are now compiled with user-defined tracepoints enabled.
6d8711a
to
1dcf31e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack (once CI sorted), but please stop printing every trace to stderr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing systemtap-sdt-dev
in contrib/reprobuild/Dockerfile.focal
and contrib/reprobuild/Dockerfile.jammy
results in multiple 'unmet dependencies' errors.
Can we also confirm if some of these Dockerfiles are even actively being used? For instance, contrib/docker/Dockerfile.builder (using Ubuntu 16.04) throws an 'Unable to locate package lowdown' error, and contrib/docker/Dockerfile.tester (using Ubuntu 22.04) throws an 'Unable to locate package postgresql-10' error. Both of these errors occur even without installing the new library.
I am still running test script for ./Dockerfile's new install. I will update once it is finished.
Turns out I need a couple more iterations, I'm hoping to have a durable fix for this asap. |
Looks like I missed one mismatched span pointer. To avoid this going
forward we also enable
systemtap-sdt-dev
on all builds on CI, and inreprobuilds, because we want operators to have the option of just
starting to trace.
Added @ShahanaFarooqui as reviewer since she revisited the reprobuild
recently, and we should likely discuss if tracing enabled everywhere
is as desirable as I think :-)
Closes #7843