Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest: allow a second gossip filter in test #7851

Conversation

endothermicdev
Copy link
Collaborator

Not sure why this didn't cause a problem in 7768, but I'm assuming that's the cause. The extra timestamp filter message is allowing gossipwith to cut off before catching the last channel update.

Fixes: 7849

Changelog-None

Important

24.11 FREEZE NOVEMBER 7TH: Non-bugfix PRs not ready by this date will wait for 25.02.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@cdecker
Copy link
Member

cdecker commented Nov 22, 2024

ACK 222c137

@cdecker cdecker enabled auto-merge (rebase) November 22, 2024 10:12
auto-merge was automatically disabled November 22, 2024 10:28

Rebase failed

@endothermicdev
Copy link
Collaborator Author

Already addressed by commit 8566370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants