Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the invoice #9

Open
ZmnSCPxj-jr opened this issue Oct 13, 2022 · 0 comments
Open

Drop the invoice #9

ZmnSCPxj-jr opened this issue Oct 13, 2022 · 0 comments

Comments

@ZmnSCPxj-jr
Copy link

Rather than use an invoice, we could just negotiate the on-Lightning HTLC details directly. The only relevant details are the on-Lightning channel ID, amount, timelock, and hash (or point once PTLCs are deployed)

The invoice spec is open-ended, and there may be future new fields added which affect how payment is done. Ideally the peerswap spec would require that any future unknown fields are simply not allowed. as we cannot predict how those would affect a standard invoice-paying implementation.

A robust peerswap implementation would have to itself parse the invoice, and ignore any unknown fields, just getting the minimal information, just to avoid the possibility that new fields may effect the payment algorithm in unexpected and unknown ways. Then it has to pas on those details to some low-level HTLC-offerring code. This means that the invoice format is not an advantage, and is potentially just a liability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant