-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secp operations during txid computation #202
Comments
Sure. What secp function was it? |
I had to leave the PC... I remember |
Here are a convenient screenshot and the profiler json (to be loaded from chrome dev tools, performance tab) For what I understand is how the PedersenCommitment is serialized with |
Ok, yeah, the issue is in libsecp256k1-zkp, not here. For some bizarre reason |
Issue has been fixed in the upstream lib, I think we need
|
Bumping secp-zkp requires bumping secp, which requires bumping bitcoin, which requires bumping bitcoind, which requires bumping elementsd. I am almost done this. Opened RCasatta/elementsd#18 |
The next version of rust-bitcoin will break out the "types that never change" into a new |
Fixed with #209 |
In a performance profile in a downstream project I noticed
txid()
is taking too much time even considering it's an expensive computation, in the flame graph there were calls to secp function which I don't think should happen?Can share the performance graph if can help understand
The text was updated successfully, but these errors were encountered: