Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitting acceptor errors terminates the really slow search for licenses #12

Open
WildCryptoFox opened this issue Dec 6, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@WildCryptoFox
Copy link

WildCryptoFox commented Dec 6, 2019

cargo about generate stops looking for licenses after it finds a license which was not accepted. This is especially annoying when working with many files as the current iteration approach is really quite slow.

For comparison. ripgrep even with --no-ignore flies through all my files almost immediately. It would be worth taking a few pages out of rg's book.

Edit: cargo license does not do the deep analysis to find licenses but is immediate to give feedback.

@WildCryptoFox WildCryptoFox added the bug Something isn't working label Dec 6, 2019
@MaikKlein MaikKlein added enhancement New feature or request and removed bug Something isn't working labels Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants